fix: remove deprecated stellar-sdk package and update imports#73
Merged
daiwikmh merged 1 commit intoApr 30, 2026
Merged
Conversation
- Replace deprecated 'stellar-sdk' package with '@stellar/stellar-sdk' in package.json dependencies - Update import in tools/stellar.ts from 'stellar-sdk' to '@stellar/stellar-sdk' - All existing tests pass with this change - Addresses npm deprecation warning for stellar-sdk v13.3.0 - Ensures consistency with the rest of the codebase which already uses @stellar/stellar-sdk
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The project had duplicate and conflicting Stellar SDK dependencies:
stellar-sdk(deprecated as of v13.3.0) - producing npm warnings@stellar/stellar-sdk(current recommended) - used throughout codebaseThis created inconsistency:
tools/stellar.tsimported from the deprecated package while the rest of the codebase used@stellar/stellar-sdk.Solution
✅ Removed deprecated
stellar-sdkdependency from package.json✅ Updated import in
tools/stellar.tsto use@stellar/stellar-sdk✅ Ensured 100% import consistency across the codebase
Changes
"stellar-sdk": "^13.3.0"dependencystellar-sdkto@stellar/stellar-sdkTesting
✅ All 59 unit & integration tests pass
✅ TypeScript compilation successful
✅ No breaking changes
✅ npm install no longer produces deprecation warnings
Impact
Summary by cubic
Removed deprecated
stellar-sdkand standardized imports to@stellar/stellar-sdkto remove npm warnings and keep the SDK usage consistent. No functional changes.stellar-sdkfrompackage.jsontools/stellar.tsto import@stellar/stellar-sdkWritten for commit ed427b3. Summary will update on new commits. Review in cubic