feat: add React frontend with Stellar Wallets Kit integration#62
Closed
murat48 wants to merge 4 commits into
Closed
feat: add React frontend with Stellar Wallets Kit integration#62murat48 wants to merge 4 commits into
murat48 wants to merge 4 commits into
Conversation
Author
There was a problem hiding this comment.
4 issues found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/style.css">
<violation number="1" location="frontend/src/style.css:407">
P2: Long wallet addresses may overflow in the flex address bar because the truncating element lacks `min-width: 0`/flex sizing, preventing reliable ellipsis behavior.</violation>
</file>
<file name="frontend/src/components/SwapPanel.tsx">
<violation number="1" location="frontend/src/components/SwapPanel.tsx:101">
P2: Route selection in the UI is not honored during swap execution; swap always uses internally re-quoted first route.</violation>
<violation number="2" location="frontend/src/components/SwapPanel.tsx:109">
P2: Unvalidated `parseInt` on slippage can pass `NaN` into swap execution, leading to invalid transaction parameters and runtime failure.</violation>
</file>
<file name="frontend/src/lib/stellar.ts">
<violation number="1" location="frontend/src/lib/stellar.ts:60">
P1: Soroban `sendTransaction` response is not validated; code returns hash before confirming final transaction success.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
3 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/SwapPanel.tsx">
<violation number="1" location="frontend/src/components/SwapPanel.tsx:99">
P2: Slippage validation omits the declared upper bound, allowing out-of-range values to be used in swap execution.</violation>
</file>
<file name="frontend/src/lib/stellar.ts">
<violation number="1" location="frontend/src/lib/stellar.ts:137">
P2: Providing `route` bypasses required-amount validation, but swap construction still uses non-null asserted `sendAmount`/`destAmount`, allowing runtime undefined values.</violation>
<violation number="2" location="frontend/src/lib/stellar.ts:138">
P2: `executeSwap` trusts caller-provided `route` without validating it against current swap inputs, allowing stale route data to drive path/slippage bounds and causing incorrect execution constraints.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/SwapPanel.tsx">
<violation number="1" location="frontend/src/components/SwapPanel.tsx:99">
P2: Slippage constraints are inconsistent: runtime allows up to 10000 bps while the input field still declares max 5000.</violation>
</file>
<file name="frontend/src/lib/stellar.ts">
<violation number="1" location="frontend/src/lib/stellar.ts:149">
P2: Route reuse validation is incomplete: it only compares one amount string and can accept stale routes from changed inputs or reject equivalent amounts due to formatting.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
|
ci checks failing |
Contributor
|
ci checks fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Added a React + TypeScript frontend for Stellar AgentKit using wallet kit (no secret key input).
Changes
frontend/): Vite + React 18 + TypeScript setup@creit-tech/stellar-wallets-kitv2.1.0 for wallet connection (Freighter, LOBSTR, etc.)publicKey,signXdr)SwapPanel: DEX token swap operationsLiquidityPanel: Add/remove liquidityPaymentPanel: Send XLM/token paymentsTech Stack
@creit-tech/stellar-wallets-kitv2.1.0Summary by cubic
Adds a React + TypeScript Testnet frontend with
@creit-tech/stellar-wallets-kitfor wallet connect and signing so users can send payments, swap assets, and manage liquidity without secret keys. Improves swap safety with stricter slippage limits, input validation, and more reliable route checks.New Features
frontend/.@creit-tech/stellar-wallets-kit(header button, global state, Testnet only).Bug Fixes
Written for commit 6381db0. Summary will update on new commits.