fix(design-system): improve trust badge and feedback accessibility#1054
Open
snkk2x-collab wants to merge 1 commit into
Open
fix(design-system): improve trust badge and feedback accessibility#1054snkk2x-collab wants to merge 1 commit into
snkk2x-collab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #967
Before / After
Before, a tooltip-enabled trust badge rendered as a non-focusable span, so keyboard users could not reach the explanation. Feedback notifications also always used spring motion. After this change, tooltip badges expose a keyboard focus target and accessible state explanation, while feedback toasts use near-static opacity transitions when reduced motion is requested.
Validation
pnpm exec vitest run src/features/design-system/components/trust-badge.test.tsxpnpm exec tsc --noEmitpnpm exec eslint src/features/design-system/components/trust-badge.tsx src/features/design-system/components/trust-badge.test.tsx src/features/design-system/feedback/feedback-viewport.tsx