feat: resolve keyboard access and visible focus order gaps#1049
Open
Johnsource-hub wants to merge 1 commit into
Open
feat: resolve keyboard access and visible focus order gaps#1049Johnsource-hub wants to merge 1 commit into
Johnsource-hub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes
#977
Description
This PR addresses mobile layout usability, keyboard flow navigation, and web accessibility (a11y) considerations across the core responsive messaging layouts. It repairs hidden interaction points, updates ARIA landmark state configurations, and ensures native support for system motion preferences.
Problem Statement
Tabarrays.Technical Changes & Wins
Sidebar.tsx): Implemented absolute visual and behavioral blocking (invisible,pointer-events-none, and dynamictabIndex={-1}) on hidden layout components. This keeps off-screen sidebar options completely outside the keyboard navigation sequence when closed.Topbar.tsx,BottomNavigation.tsx): Appended descriptivearia-label,aria-expanded, andaria-controlsbindings to all icon-only buttons to convey operational context explicitly to screen readers.use-mobile.tsx): Expanded the mobile detection hook with a query listener for(prefers-reduced-motion: reduce). This bypasses sliding transitions instantly for users with motion sensitivities.Affected Path Scopes
src/hooks/use-mobile.tsxsrc/components/mail/Sidebar.tsxsrc/components/mail/Topbar.tsxsrc/components/mail/BottomNavigation.tsxScope Guardrails Compliance
Verification & Testing
TabandEnter/Space.