Skip to content

Add inline script environment lifecycle telemetry (PEP 723 PR 15/16) - #4

Closed
StellaHuang95 wants to merge 1 commit into
mainfrom
pep723-pr15-telemetry
Closed

Add inline script environment lifecycle telemetry (PEP 723 PR 15/16)#4
StellaHuang95 wants to merge 1 commit into
mainfrom
pep723-pr15-telemetry

Conversation

@StellaHuang95

@StellaHuang95 StellaHuang95 commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Draft fork-review PR. Do not send upstream yet.

Summary

  • add inlineScript.envCreated
  • add inlineScript.envReuseHit
  • add inlineScript.envError
  • define typed GDPR-safe schemas and stable low-cardinality error categories

Semantics

  • emit creation only after verified environment creation and sidecar persistence
  • measure actual build/rebuild duration, excluding lock wait and cache inspection
  • emit reuse only after complete cache validation
  • emit one lifecycle result for an underlying coalesced operation rather than per waiter
  • distinguish discovery failure, no compatible Python, user decline, install failure, package cancellation, lock timeout, and unavailable retained/orphaned locks
  • send no URI, path, version, dependency value, requirement, package name, or error-message content
  • preserve existing uv prompts, installation behavior, and uv telemetry

Scope

This is telemetry-only. It does not add routing, discovery, cleanup, UI, project registration, retries, or cache algorithm changes.

Validation

  • TypeScript test compilation
  • ESLint and diff checks
  • focused unit suite: 137 passing
  • two manual telemetry/code-path review passes; no significant findings remain

@StellaHuang95
Add inline script environment lifecycle telemetry
3d5a6d9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3cb82ae9-7424-40a4-9156-8c54ac6e0895
@StellaHuang95
StellaHuang95 marked this pull request as ready for review August 17, 2026 17:07
@StellaHuang95 StellaHuang95 added review-auto:changes-requested Automated review: posted blocking findings to address. and removed review-auto:changes-requested Automated review: posted blocking findings to address. labels Aug 17, 2026
@StellaHuang95

StellaHuang95 commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

Closing this PR in favor of a clean-history replacement with the same current reviewed file changes.

@StellaHuang95 StellaHuang95 mentioned this pull request Aug 17, 2026
Closed
@StellaHuang95

StellaHuang95 commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by clean-history replacement #10.

StellaHuang95 added a commit that referenced this pull request Aug 25, 2026
@StellaHuang95
refactor: trim PR scope to lock retirement, serialized clears, inline…
600e56f 
…-key preservation

Reduce this PR's net diff versus its merge-base to only three logical changes:

- #3 atomic canonical lock retirement on release (src/common/lockfile.apis.ts)
- #6 serialized persistent-state clears (src/common/persistentState.ts)
- #7 generic Clear Cache preserves the inline association key
  (constants.ts, envCommands.ts, extension.ts, and an import-only change in
  the inline-script envManager)

Revert the other seven changes to the merge-base content:
- #1 root-generation nonce, #2 root/entry admission decoupling,
  #9 create-counting order (inline-script envManager)
- #4/#5 reclaim-side lock retirement + generation-specific inspection
  (keep only the minimal release-side companions inspect/reclaim need to
  stay correct: .release-* recognition and ENOENT-on-readdir tolerance)
- #8 workspace-root protection (settingHelpers)
- #10 typed ClearCacheNotSupported (envManagers, NotSupportedError)

Also revert the associated test changes for the removed items, keeping the
new persistentState suite (#6), the new Clear Environment Caches suite (#7),
and the release-side lock-retirement tests (#3).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
StellaHuang95 added a commit that referenced this pull request Aug 26, 2026
@StellaHuang95
refactor: trim PR scope to lock retirement, serialized clears, inline…
78c8f17 
…-key preservation

Reduce this PR's net diff versus its merge-base to only three logical changes:

- #3 atomic canonical lock retirement on release (src/common/lockfile.apis.ts)
- #6 serialized persistent-state clears (src/common/persistentState.ts)
- #7 generic Clear Cache preserves the inline association key
  (constants.ts, envCommands.ts, extension.ts, and an import-only change in
  the inline-script envManager)

Revert the other seven changes to the merge-base content:
- #1 root-generation nonce, #2 root/entry admission decoupling,
  #9 create-counting order (inline-script envManager)
- #4/#5 reclaim-side lock retirement + generation-specific inspection
  (keep only the minimal release-side companions inspect/reclaim need to
  stay correct: .release-* recognition and ENOENT-on-readdir tolerance)
- #8 workspace-root protection (settingHelpers)
- #10 typed ClearCacheNotSupported (envManagers, NotSupportedError)

Also revert the associated test changes for the removed items, keeping the
new persistentState suite (#6), the new Clear Environment Caches suite (#7),
and the release-side lock-retirement tests (#3).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@StellaHuang95