Add inline-script environment creation tests (PEP 723 PR 5/16 - tests) - #2
Closed
StellaHuang95 wants to merge 1 commit into
Closed
Add inline-script environment creation tests (PEP 723 PR 5/16 - tests)#2StellaHuang95 wants to merge 1 commit into
StellaHuang95 wants to merge 1 commit into
Conversation
Unit tests for the inline-script environment creation path: cache key, cache layout, interpreter selection, cross-process lockfile, venv python path, process cancellation, createWithProgress options, and the InlineScriptEnvManager create/reuse flow. Based on the implementation branch so this PR shows only the test changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 39dcc6a3-0fbd-4f36-9d0f-68677de49c27
StellaHuang95
added a commit
that referenced
this pull request
Aug 25, 2026
…-key preservation Reduce this PR's net diff versus its merge-base to only three logical changes: - #3 atomic canonical lock retirement on release (src/common/lockfile.apis.ts) - #6 serialized persistent-state clears (src/common/persistentState.ts) - #7 generic Clear Cache preserves the inline association key (constants.ts, envCommands.ts, extension.ts, and an import-only change in the inline-script envManager) Revert the other seven changes to the merge-base content: - #1 root-generation nonce, #2 root/entry admission decoupling, #9 create-counting order (inline-script envManager) - #4/#5 reclaim-side lock retirement + generation-specific inspection (keep only the minimal release-side companions inspect/reclaim need to stay correct: .release-* recognition and ENOENT-on-readdir tolerance) - #8 workspace-root protection (settingHelpers) - #10 typed ClearCacheNotSupported (envManagers, NotSupportedError) Also revert the associated test changes for the removed items, keeping the new persistentState suite (#6), the new Clear Environment Caches suite (#7), and the release-side lock-retirement tests (#3). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
StellaHuang95
added a commit
that referenced
this pull request
Aug 26, 2026
…-key preservation Reduce this PR's net diff versus its merge-base to only three logical changes: - #3 atomic canonical lock retirement on release (src/common/lockfile.apis.ts) - #6 serialized persistent-state clears (src/common/persistentState.ts) - #7 generic Clear Cache preserves the inline association key (constants.ts, envCommands.ts, extension.ts, and an import-only change in the inline-script envManager) Revert the other seven changes to the merge-base content: - #1 root-generation nonce, #2 root/entry admission decoupling, #9 create-counting order (inline-script envManager) - #4/#5 reclaim-side lock retirement + generation-specific inspection (keep only the minimal release-side companions inspect/reclaim need to stay correct: .release-* recognition and ENOENT-on-readdir tolerance) - #8 workspace-root protection (settingHelpers) - #10 typed ClearCacheNotSupported (envManagers, NotSupportedError) Also revert the associated test changes for the removed items, keeping the new persistentState suite (#6), the new Clear Environment Caches suite (#7), and the release-side lock-retirement tests (#3). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR adds
New suites:
lockfile.apis.unit.test.ts— 9 tests: contention, retain/fail-fast, orphaned and compromised locks, and timeout.venvUtils.createWithProgress.unit.test.ts— 3 tests fortrackUvEnvironmentandpkgInstallationCancelled.helpers.cancellation.unit.test.ts— 4 tests forrunProcesscancellation safety.virtualEnvironment.unit.test.ts— 2 tests forgetVenvPythonPathon Windows and POSIX.Expanded / updated suites:
inlineScriptEnvManager.unit.test.ts— 40 tests across scope/metadata validation, base-interpreter selection, cache creation, cache reuse, transaction rollback, and events/disposal.inlineScriptCacheLayout.unit.test.ts,inlineScriptCacheKey.unit.test.ts,inlineScriptInterpreter.unit.test.ts— cover the new/changed layout, cache-key, and interpreter-selection helpers.inlineScriptMain.unit.test.ts— updated for the newregisterInlineScriptFeaturessignature.With both PRs applied,
npm run unittestreports 1487 passing, 0 failing, 5 pending.Merge order
Merge microsoft#1651 first. After it lands in
main, this PR can be retargeted tomainwith no change to its diff (still tests only).