extend feature of datapack (without breaking parity)#243
Open
coco875 wants to merge 57 commits into
Open
Conversation
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
# Conflicts: # steel-registry/build/template_pools.rs
|
Conflicts have been resolved! 🎉 |
Merged
Contributor
Author
I have check and it match vanilla, will do a quick self review
|
… from datapack-overlay
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr add alias that datapack can (datapack can use minecraft:noise and noise for example), modify some type to better corespond to all types that field can accept (like for color using both string and number) and other adjustement.
Why doing this ?
While the vanilla datapack for now don't use all of this, it's possible value that the datapack can evolve to, so doing now avoid to doing later when they do the change. I also have another branch that this time allow to build steel with datapack (only json not mcfunction) coco875#2.