Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
Plugin Testing ReportI manually installed the plugin at the commit referenced by this PR's submodule. Installed Plugins
Specifications
IssuesHas the following major blocking issue(s): N/A SummaryTested with a few different Bluetooth devices that report their battery life
Devices tested with:
|
Testing report — Bluetooth v3.0.0Hardware: Steam Machine (not a Deck), SteamOS Stable, Decky Loader 3.2.6, BlueZ 5.83, single adapter Works
Issues1. The device row doesn't update after you connect or disconnect it. In export async function toggleDeviceConnection(device: Device): Promise<void> {
controller.toggleDeviceConnection(device.mac, device.connected).catch(console.error);
}The inner promise isn't returned, so the 2. D-Bus error replies are never checked. 3.
4. The battery readout won't fire for PlayStation controllers. A 5. 6. Hardcoded 7. Minor: with no paired devices the list renders as an empty gap — no "no devices" message. One loose end: this turned up once in the plugin log during connect testing and I could not establish what produced it, so take it as an observation rather than a diagnosis. Not testedA device that actually exposes |
|
Thanks for testing @jwhitlow45 and @zomars and thanks for the feedbacks. |
|
@zomars just reviewed it and posted a report on your PR, LGTM! |
|
@zomars @jwhitlow45 I've taken your feedback into account and updated the PR to |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
Yes I'm just waiting for the PR to be merged... |
Yeah, sorry, we are a bit slow lately. I'll see if I can find some time for it :) |
|
I don't understand how can I test this and provide a report ? in the decky Testing Store I only see the version 2.3.1 |
Update Bluetooth to v3.1.0
The store still serves 2.3.1, so this covers both the 3.0.0 rewrite and the 3.1.0 fixes that came out of the testing on this PR.
bluetoothctlreplacement withD-BusPlugin used subprocess calls to
bluetoothctlsince the beginning but it was always a bit unreliable because it conflicted with Steam. Then Steam sharedSteamClient.System.Bluetoothwhich was much more reliable but it did not last long as they removed it.Fed up with this and getting issues opened I finally took some time and switched the project to using
dbuswith thejeepneypython library instead.Devices now display properly and also got the added bonus to retrieve the current battery level if available.
Full changelog
3.0.0
bluetoothctlsubprocess calls3.1.0 — from the testing reports on this PR and on issue #19
Connecting/Disconnectinglabel while the call runsNot connectedConnect/Disconnectinstead ofSelectGetManagedObjects(), no longer assuminghci0Task Checklist
Developer
Plugin
Backend
Community
Testing