(no-task): add configurable PinAdapter for encrypted/plain pin modes#49
Open
feeland3 wants to merge 3 commits into
Open
(no-task): add configurable PinAdapter for encrypted/plain pin modes#49feeland3 wants to merge 3 commits into
feeland3 wants to merge 3 commits into
Conversation
Introduces PinAdapter/PinAdapterImpl, switchable via pin.security.mode property (default: plain, encrypted uses BCrypt). Replaces direct BCryptPasswordEncoder usage and plain .equals() checks across card controllers and BankCardServiceImpl with the adapter, so both storage modes coexist behind one property instead of forking the codebase. Test fixtures switched from bcrypt hashes to plain pin values and pin.security.mode=plain pinned explicitly in test-application.properties.
Checkstyle NewlineAtEndOfFile rule failed CI build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.