Skip to content

A pause near the end of a server book can lose the finished flag #82

Closed

Description

@StaticHumStudio

What

When playback pauses within the last second of a book that has a live server session, the pause save goes through syncTerminalProgress and saveSessionProgressOrEnqueue. The session request carries no finished flag, and on success ProgressRepository deletes any queued explicit finished update. The book can stay unfinished on the server.

Bite

Listeners who pause right at the end (or the player stops a hair early) may see the book as unfinished on other devices.

Proposed shape

When the saved position counts as finished (positionCountsAsFinished), send or keep the explicit finished progress update instead of letting the session save delete it.

Why not in the big-library build

Pre-existing server session behavior, found by review round 4, not caused by the build.

🤖 Generated with Claude Code

Activity

  1. StaticHumStudio commented on Oct 4, 2026

    @StaticHumStudio
    OwnerAuthor

    Fixed in #90 (650f374), ships in 2.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions