Guard against losing project description changes#311
Open
dibyanshu-pal-kushwaha wants to merge 2 commits intoStatTag:masterfrom
Open
Guard against losing project description changes#311dibyanshu-pal-kushwaha wants to merge 2 commits intoStatTag:masterfrom
dibyanshu-pal-kushwaha wants to merge 2 commits intoStatTag:masterfrom
Conversation
lrasmus
requested changes
Feb 4, 2026
Contributor
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
One minor UI change, but this appears to handle very well the situation where a user clicks on another project and has pending changes!
| open={this.state.showDirtyConfirmation} | ||
| onClose={this.handleCancelSwitch} | ||
| > | ||
| <DialogTitle>Discard Changes?</DialogTitle> |
Contributor
There was a problem hiding this comment.
Minor UI change - the dialog title needs to be manually adjusted:
We had to do this in another dialog too, just setting the style to white.
There was a problem hiding this comment.
@lrasmus , Please review this pr and help me to fix it if needed sir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR Prevents users from accidentally losing unsaved edits to the Project Description when navigating between projects.
Fixes : #284
Changes :
Screenshots :
Before Editing the current project :
After Editing , trying to click another project then this Discards Change Card appears for confirmation :
Steps to Test :
2.Click on the Edit the details of the Project -> Trying editing the description.
3.Now try to click onto other projects , a Discard Changes Card will pop up to confirm the changes done by you.
4.When you cancel it , your changes remains there and you do not move to the other project.
Clearly we are able to solve the issue of losing the project description changes accidentally by opening other projects.