Added functionality to open file from assets#301
Open
debangi29 wants to merge 1 commit intoStatTag:masterfrom
Open
Added functionality to open file from assets#301debangi29 wants to merge 1 commit intoStatTag:masterfrom
debangi29 wants to merge 1 commit intoStatTag:masterfrom
Conversation
lrasmus
requested changes
Jan 26, 2026
Contributor
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
Looking really good overall - sorry for the delay to look at this. More detail in the tagged comment about possible changes. Thanks!
| if (asset) { | ||
| const filePath = asset.uri; | ||
| if (filePath) { | ||
| fileActions = ( |
Contributor
There was a problem hiding this comment.
Could we make a few modifications to the available actions here? One of these is a new request I did not think of originally, so it can be considered out of scope.
- For a folder, "Open File" works, but does the same action as "Show in Folder". We should hide the "Open File" action if the asset type is a folder
- For external resources, these options should not be available
- (New request) For external resources, because those would be a URL, the action could be "Open URL" or "Open Link"
If possible to address 1 & 2 in this PR, that would be great. Item 3 is expanding the scope of this request, but if you would be willing to tackle it that would be awesome.
Contributor
Author
There was a problem hiding this comment.
Sure sir, I will fix this ASAP!!
Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue #290
Similar Functionality as Show in folder and Open file in Search feature