Add Code Guards for Airlocks Without Wires#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the integration tests failed:
https://github.com/Starfly-13/sf13/actions/runs/24620249359/job/71989545373
Looks like a wooden airlock without wires spawned near a goliath pup who bumped into the airlock.
It wanted to check if the airlock needed an ID, and if so if the goliath pup had an ID to pass through the airlock.
However, because the airlock did not have wires, it couldn't call
is_cut()on anull.This PR adds some code guards in the airlock class everywhere
wiresis used.If there are no wires, we just do nothing instead of crashing.