Repository navigation
fix(index): skip indented comment lines in WebSource url files - #169
Open
longzhenren wants to merge 1 commit into
Open
longzhenren wants to merge 1 commit into
longzhenren wants to merge 1 commit into
Conversation
The emptiness check used the stripped line while the comment check used the raw line, so indented or tab-prefixed comments were collected as URLs. Strip each line once and apply both checks to the cleaned value.
|
@longzhenren is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
WebSource.__init__parsed url files with:The emptiness check used the stripped line but the comment check used the raw line, so a comment with leading whitespace or a tab was treated as a URL and entered the render/index pipeline.
Repro on
main:Fix
Strip each line once and apply both checks to the cleaned value (walrus in the comprehension).
Test
Added
tests/test_web_source_urls.pycovering plain URLs, indented/tab comment lines, blank and full-line comments, and whitespace stripping.