Repository navigation
feat(deck): add multi-select filters to card restrictions - #64
Merged
TONY-All merged 2 commits intoOct 24, 2026
Merged
Conversation
The restriction dialog's filters were a hand-built copy of the shared card filter panel, and they mixed members and Snaps in one rarity row: Snap rarities showed member icons, and 2-4 star chips matched both kinds at once. - Show one kind at a time (member / Snap tabs when the box holds both) and filter it with useCardFilters + <CardFilters>, so each kind gets its own rarity scale and icons, the NFKC multi-word search, sorting, and the character filter of the other card pickers. - The all / required / excluded tab narrows the list through the controller's match, so the band and rarity options stay those of the whole kind. - Whenever the shown kind changes (picked, or the box lost the other kind), the filters reset but keep the search, so no filter stays on without its chip. - Drop constraintCount and constraintEmpty: the shared panel shows the count, and the empty list reuses deckWorkspace.emptyCards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Thanks for this, @Hugefunny! The filters are a nice addition. I pushed a follow-up commit (40cb1aa) to your branch instead of asking for another round, since the changes were mostly about wiring it into existing pieces: What changed
Checked
Let me know if you'd rather keep a mixed member + Snap view. That would need 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.