Repository navigation
audit: simplify presentation task cancellation checks - #150
Merged
StanleyLl0yd merged 3 commits intoOct 12, 2026
Merged
Conversation
StanleyLl0yd
deleted the
audit/async-cancellation-guard-simplification
branch
October 12, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-requested repository-wide audit #145.
Exact starting main:
d5906be1bf04139c673f2746954e8ed94d1502e4.Scope: behavior-preserving simplification of the synchronous cancellation guards used by Tree, Search, Largest Files, and Sunburst derived presentation preprocessors.
withUnsafeCurrentTask { task in task?.isCancelled ?? false }computed properties with the standard Swift 6Task.isCancelledaccess at the existing guard sites.Exactly three changed files:
ContentView.swift,Utilities.swift,DiskUsageTests/FolderUsageTests.swift.No scanner, model, filesystem, Trash, resource, release, CI, dependency or roadmap change.
Hold merge until prior #149 exact-main is fully green, and this PR's own exact-head CI/Security/Dependency Review/CodeQL Actions+Swift and zero review threads pass. Verify merged main afterward.