Skip to content

chore(deps): #143 take laravel-dev-tools 4.13.0, drop workarounds - #144

Merged
Stanislas-Poisson merged 1 commit into
developfrom
chore/#143-laravel-dev-tools-4.13.0
Nov 8, 2026
Merged

Stanislas-Poisson merged 1 commit into
developfrom
chore/#143-laravel-dev-tools-4.13.0

Conversation

@Stanislas-Poisson

Copy link
Copy Markdown
Owner

Summary

Refs #143.

Take zairakai/laravel-dev-tools 4.13.0 (with stanislas-poisson/php-dev-tools 1.1.3), which builds its Rector, PHPInsights, Pint, markdownlint and PHPStan configuration on php-dev-tools, and remove the workarounds that it makes useless:

  • config/dev-tools/rector.php: the withRules([AddOverrideAttributeToOverriddenMethodsRector::class]) that only silenced a warning. The package no longer skips that deprecated rule.
  • config/dev-tools/insights.php: the three exclusions (public properties of Eloquent and jobs, generics of Eloquent relations, methods of enums). The base excludes them by directory.
  • composer.json: the scripts quality, quality:fast, quality:fix and cs:fix that the package adds (the hooks of php-dev-tools run them).

The phpstan.neon list of ignored strict rules (#141) stays: PHPStan reports no unmatched ignore, so the five identifiers all match.

Tests

Rector (no warning left: no skipped rule, no deprecated skip, no naming), PHPStan (no error), PHPInsights (100 %, 99.6 %, 100 %, 98.6 %), Pint, markdownlint and the unit tests (37) pass.

laravel-dev-tools 4.13.0 builds its configuration on php-dev-tools 1.1.3 and no
longer skips the deprecated AddOverrideAttributeToOverriddenMethodsRector, and
its PHPInsights base excludes Eloquent and enums by directory. Remove the
withRules() of Rector and the three exclusions of PHPInsights that worked
around it.
@Stanislas-Poisson
Stanislas-Poisson merged commit 3d32a3e into develop Nov 8, 2026
1 check passed
@Stanislas-Poisson
Stanislas-Poisson deleted the chore/#143-laravel-dev-tools-4.13.0 branch November 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant