Repository navigation
chore(deps): #143 take laravel-dev-tools 4.13.0, drop workarounds - #144
Merged
Merged
Conversation
laravel-dev-tools 4.13.0 builds its configuration on php-dev-tools 1.1.3 and no longer skips the deprecated AddOverrideAttributeToOverriddenMethodsRector, and its PHPInsights base excludes Eloquent and enums by directory. Remove the withRules() of Rector and the three exclusions of PHPInsights that worked around it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #143.
Take
zairakai/laravel-dev-tools4.13.0 (withstanislas-poisson/php-dev-tools1.1.3), which builds its Rector, PHPInsights, Pint, markdownlint and PHPStan configuration onphp-dev-tools, and remove the workarounds that it makes useless:config/dev-tools/rector.php: thewithRules([AddOverrideAttributeToOverriddenMethodsRector::class])that only silenced a warning. The package no longer skips that deprecated rule.config/dev-tools/insights.php: the three exclusions (public properties of Eloquent and jobs, generics of Eloquent relations, methods of enums). The base excludes them by directory.composer.json: the scriptsquality,quality:fast,quality:fixandcs:fixthat the package adds (the hooks ofphp-dev-toolsrun them).The
phpstan.neonlist of ignored strict rules (#141) stays: PHPStan reports no unmatched ignore, so the five identifiers all match.Tests
Rector (no warning left: no skipped rule, no deprecated skip, no
naming), PHPStan (no error), PHPInsights (100 %, 99.6 %, 100 %, 98.6 %), Pint, markdownlint and the unit tests (37) pass.