Skip to content

chore(phpstan): #141 ignore the strict rules not followed yet - #142

Merged
Stanislas-Poisson merged 1 commit into
developfrom
chore/#141-phpstan-strict-ignores
Nov 8, 2026
Merged

Stanislas-Poisson merged 1 commit into
developfrom
chore/#141-phpstan-strict-ignores

Conversation

@Stanislas-Poisson

Copy link
Copy Markdown
Owner

Summary

Refs #141.

The next version of laravel-dev-tools includes the PHPStan configuration of php-dev-tools (level max, phpstan-strict-rules, phpstan-phpunit) and no longer hides the strict rules. List the ones that this project does not follow yet, to reduce one by one:

  • staticMethod.dynamicCall (506 errors: the $this->assert... of the tests)
  • method.childReturnType (6)
  • ternary.shortNotAllowed (2)
  • ternary.condNotBoolean (2)
  • booleanNot.exprNotBoolean (1)

The ignores that no longer match are reported by PHPStan, so the list only holds what matches.

Tests

PHPStan: no error with the current laravel-dev-tools (4.11.0) and with the new base (strict rules, no shared list).

Five identifiers, to reduce rule by rule. The base of laravel-dev-tools now
includes the strict rules of php-dev-tools and no longer hides them.
@Stanislas-Poisson
Stanislas-Poisson merged commit da41b06 into develop Nov 8, 2026
1 check passed
@Stanislas-Poisson
Stanislas-Poisson deleted the chore/#141-phpstan-strict-ignores branch November 8, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant