Repository navigation
chore(phpstan): #141 ignore the strict rules not followed yet - #142
Merged
Merged
Conversation
Five identifiers, to reduce rule by rule. The base of laravel-dev-tools now includes the strict rules of php-dev-tools and no longer hides them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #141.
The next version of
laravel-dev-toolsincludes the PHPStan configuration ofphp-dev-tools(level max,phpstan-strict-rules,phpstan-phpunit) and no longer hides the strict rules. List the ones that this project does not follow yet, to reduce one by one:staticMethod.dynamicCall(506 errors: the$this->assert...of the tests)method.childReturnType(6)ternary.shortNotAllowed(2)ternary.condNotBoolean(2)booleanNot.exprNotBoolean(1)The ignores that no longer match are reported by PHPStan, so the list only holds what matches.
Tests
PHPStan: no error with the current
laravel-dev-tools(4.11.0) and with the new base (strict rules, no shared list).