Repository navigation
fix(release): #136 count the switch to ban as a patch change - #137
Merged
Merged
Conversation
A city that gets its first point of the BAN changes coordinate_source from nominatim to ban together with the BAN columns. It was counted as another column, which made the whole change a minor release published at once. Only that switch is tolerated; any other change of the column stays minor.
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Summary
A city that gets its first point of the BAN changes
coordinate_sourcefromnominatimtobantogether withaddress_count,latitudeandlongitude. The comparison counted that column as another column, so the whole change became a minor release, published at once, instead of a patch one that waits for Monday.compare_exports.pynow tolerates that one switch (coordinate_sourcefromnominatimtoban, incities.csv) as a move of the BAN. Any other change of the column, in the other direction or to another value, and any other column, stays a minor change.docs/release.mdand the docstring say it.Checks
make qualitypasses with no new baseline entry.make testpasses and the coverage does not go down.docs/).type(scope): #TICKET subject.Not validated
make qualityandmake testwere not run in full: only the pre-commitquality-fast(Pint, PHPStan, Markdownlint) passed. The script has no automated test.