Skip to content

fix(release): #136 count the switch to ban as a patch change - #137

Merged
Stanislas-Poisson merged 1 commit into
developfrom
fix/#136-coordinate-source-patch
Nov 7, 2026
Merged

Stanislas-Poisson merged 1 commit into
developfrom
fix/#136-coordinate-source-patch

Conversation

@Stanislas-Poisson

@Stanislas-Poisson Stanislas-Poisson commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Closes #136

Summary

A city that gets its first point of the BAN changes coordinate_source from nominatim to ban together with address_count, latitude and longitude. The comparison counted that column as another column, so the whole change became a minor release, published at once, instead of a patch one that waits for Monday.

compare_exports.py now tolerates that one switch (coordinate_source from nominatim to ban, in cities.csv) as a move of the BAN. Any other change of the column, in the other direction or to another value, and any other column, stays a minor change. docs/release.md and the docstring say it.

Checks

  • make quality passes with no new baseline entry.
  • make test passes and the coverage does not go down.
  • The tests call no real network.
  • The documentation is up to date (README, docs/).
  • The commits follow type(scope): #TICKET subject.

Not validated

  • make quality and make test were not run in full: only the pre-commit quality-fast (Pint, PHPStan, Markdownlint) passed. The script has no automated test.
  • Run by hand on the CSV of the 4.1.2 release against the CSV of the dry run of 2026-11-07 (run 42421004352): the kind goes from minor to patch. Six hand-made cases gave the expected kind (nominatim to ban: patch; ban to nominatim, nominatim to another value, switch with another column, another column alone: minor; latitude alone: patch).
  • Not seen on a real build: the dry run was made before this change.

A city that gets its first point of the BAN changes coordinate_source from
nominatim to ban together with the BAN columns. It was counted as another
column, which made the whole change a minor release published at once.
Only that switch is tolerated; any other change of the column stays minor.
@Stanislas-Poisson Stanislas-Poisson added the bug Something does not work as expected in the tool label Nov 7, 2026
@Stanislas-Poisson Stanislas-Poisson self-assigned this Nov 7, 2026
@Stanislas-Poisson
Stanislas-Poisson merged commit 06b6867 into develop Nov 7, 2026
1 check passed
@Stanislas-Poisson
Stanislas-Poisson deleted the fix/#136-coordinate-source-patch branch November 7, 2026 22:58
@Stanislas-Poisson Stanislas-Poisson mentioned this pull request Nov 7, 2026
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something does not work as expected in the tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant