Repair the production deploy and stop Stampy posting unprompted - #337
Merged
Merged
Conversation
- Deploy helper appleboy/ssh-action v0.1.2 -> v1.2.5 (no Docker image build), 40-minute command timeout, manual workflow_dispatch trigger. - Build the new conda environment before stopping the running bot; a failed pull or build now leaves the old bot running and fails the run. - Timestamped environment names; earlier ones are removed after a successful start; the original "stampy" environment is kept as a fallback. - Stop the runstampy loop before stam.py and skip the deploy shell by PID instead of the 60-second age rule. - BE_SHY on in production, and Factoids respects it: Stampy only replies when addressed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appleboy/ssh-actionv0.1.2 → v1.2.5. v0.1.2 built a Docker image from Docker Hub on every run, the likeliest reason the January run failed; v1.2.5 is a plain composite action with the same inputs. Explicitcommand_timeout: 40mfor the environment build, and aworkflow_dispatchtrigger so the deploy can be re-run from the Actions tab.git pullor the build fails, the run goes red and the old bot keeps running. Environments get timestamped names; older timestamped ones are removed after a successful start, and the originalstampyenvironment is left in place as a manual fallback.runstampyloop is stopped beforestam.py(so it cannot respawn the old bot), and the deploy shell is skipped by PID rather than by the previous 60-second age rule, which no longer holds once the build runs first.SSL_CERT_FILEpoints at the new environment'scertifibundle instead of a hard-coded path, and the offline notice is capped at two minutes.BE_SHYis set for production, which makes theSillyandRandommodules answer only when addressed, andFactoidsnow honours the same flag (it used to reply unprompted 30% of the time when a message matched a stored factoid). Addressed commands, stamps and the editors' review-request handling (@reviewer,@feedback) are unchanged.🤖 Written by Claude Code