Remove orphaned agentmodels.org submodule gitlink - #237
Open
LeMurphant wants to merge 1 commit into
Open
Conversation
The repo tree carried a gitlink entry for data/raw/agentmodels.org (added in 471fd8e, June 2023) with no matching .gitmodules file. Any `git submodule foreach` therefore aborted with: fatal: No url found for submodule path 'data/raw/agentmodels.org' in .gitmodules The process '/usr/bin/git' failed with exit code 128 actions/checkout runs `git submodule foreach` in its post-job cleanup, so every CI job ended with that warning annotation. The jobs still succeeded -- cleanup swallows the failure -- but it added eight noisy annotations to each daily dataset run. The gitlink is vestigial: AgentModels.setup() in align_data/sources/ebooks/agentmodels.py clones the upstream repo into raw_data_path itself at runtime, so nothing reads a submodule here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every job in the daily dataset runs ends with a warning annotation:
Example: run 32434577749 — 8 jobs, 8 identical annotations.
Cause
The repo tree contains a gitlink entry with no matching
.gitmodulesfile:It was added in 471fd8e (June 2023);
.gitmoduleswas never committed alongside it. Anygit submodule foreachconsequently aborts with exit 128, andactions/checkoutruns exactly that in its post-job cleanup ("Removing SSH command configuration").Impact
Cosmetic only — the cleanup step swallows the failure, so jobs still report success. This just removes eight bogus annotations per daily run so real problems stay visible.
Why it's safe to drop
The gitlink is vestigial.
AgentModels.setup()clones the upstream repo itself at runtime:https://github.com/StampyAI/alignment-research-dataset/blob/main/align_data/sources/ebooks/agentmodels.py#L22-L28
Nothing reads a submodule at that path. After this change the repo has no gitlink entries at all.
🤖 Generated with Claude Code