Skani version 0.3.2#1712
Merged
Merged
Conversation
…y and apt-get autoclean instructions. The main README.md has 0.3.2 added to the versions dropdown for skani. The program specific README.md has no syntax changes. Version 0.3.2 was for bug-fixing primarily.
Collaborator
|
@staphb-dockerbuilds-diff skani 0.3.1 0.3.2 |
Dockerfile Diff: skaniComparing: 0.3.1 -> 0.3.2 --- build-files/skani/0.3.1/Dockerfile 2026-06-18 18:57:46.268268214 +0000
+++ build-files/skani/0.3.2/Dockerfile 2026-06-18 18:57:46.268352868 +0000
@@ -1,4 +1,4 @@
-ARG SKANI_VER="0.3.1"
+ARG SKANI_VER="0.3.2"
## Builder ##
FROM rust:1.90.0 AS builder
@@ -12,11 +12,11 @@
chmod +x /root/.cargo/bin/skani
## App ##
-FROM ubuntu:jammy AS app
+FROM ubuntu:noble AS app
ARG SKANI_VER
-LABEL base.image="ubuntu:jammy"
+LABEL base.image="ubuntu:noble"
LABEL dockerfile.version="1"
LABEL software="skani"
LABEL software.version=${SKANI_VER}
@@ -25,6 +25,8 @@
LABEL license="https://github.com/bluenote-1577/skani/blob/main/LICENSE"
LABEL maintainer="Kutluhan Incekara"
LABEL maintainer.email="kutluhan.incekara@ct.gov"
+LABEL maintainer2="Raheel Ahmed"
+LABEL maintainer2.email="raheelsyedahmed@gmail.com"
# copy app from builder stage
COPY --from=builder /root/.cargo/bin/skani /usr/local/bin/skani
@@ -40,8 +42,11 @@
## Test ##
FROM app AS test
-RUN apt-get update && apt-get install -y wget &&\
- wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-EC590.fasta &&\
+WORKDIR /test
+
+RUN apt-get update && apt-get install -y wget && \
+ apt-get autoclean && rm -rf /var/lib/apt/lists/* && \
+ wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-EC590.fasta && \
wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-K12.fasta
RUN skani dist e.coli-EC590.fasta e.coli-K12.fasta
\ No newline at end of file |
Kincekara
approved these changes
Jun 18, 2026
Kincekara
left a comment
Collaborator
There was a problem hiding this comment.
test looks good
#14 [test 3/3] RUN skani dist e.coli-EC590.fasta e.coli-K12.fasta
#14 0.052 [00:00:00.000] (7f9471c21800) INFO skani dist e.coli-EC590.fasta e.coli-K12.fasta
#14 0.095 [00:00:00.042] (7f9471c21800) INFO Learned ANI mode detected. ANI may be adjusted according to a regression model trained on MAGs.
#14 0.095 [00:00:00.043] (7f9471c21800) INFO Generating sketch time: 0.042976648
#14 0.105 [00:00:00.052] (7f9471c21800) INFO ANI calculation time: 0.009690709
#14 0.105 Ref_file Query_file ANI Align_fraction_ref Align_fraction_query Ref_name Query_name
#14 0.105 e.coli-K12.fasta e.coli-EC590.fasta 99.39 91.89 92.46 NC_007779.1 Escherichia coli str. K-12 substr. W3110, complete sequence NZ_CP016182.2 Escherichia coli strain EC590 chromosome, complete genome
#14 DONE 0.1s
Collaborator
|
Thank you for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Updated Dockerfile and set SKANI_VER to 0.3.2. Added a /test directory and apt-get autoclean instructions. The main README.md has 0.3.2 added to the versions dropdown for skani. The program specific README.md has no syntax changes. Version 0.3.2 was for bug-fixing primarily.