Skip to content

Skani version 0.3.2#1712

Merged
Kincekara merged 1 commit into
StaPH-B:masterfrom
RaheelSyedAhmed:skani-0.3.2
Jun 18, 2026
Merged

Skani version 0.3.2#1712
Kincekara merged 1 commit into
StaPH-B:masterfrom
RaheelSyedAhmed:skani-0.3.2

Conversation

@RaheelSyedAhmed

Copy link
Copy Markdown
Contributor

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Updated Dockerfile and set SKANI_VER to 0.3.2. Added a /test directory and apt-get autoclean instructions. The main README.md has 0.3.2 added to the versions dropdown for skani. The program specific README.md has no syntax changes. Version 0.3.2 was for bug-fixing primarily.

…y and apt-get autoclean instructions. The main README.md has 0.3.2 added to the versions dropdown for skani. The program specific README.md has no syntax changes. Version 0.3.2 was for bug-fixing primarily.
@Kincekara

Copy link
Copy Markdown
Collaborator

@staphb-dockerbuilds-diff skani 0.3.1 0.3.2

@github-actions

Copy link
Copy Markdown

Dockerfile Diff: skani

Comparing: 0.3.1 -> 0.3.2

--- build-files/skani/0.3.1/Dockerfile	2026-06-18 18:57:46.268268214 +0000
+++ build-files/skani/0.3.2/Dockerfile	2026-06-18 18:57:46.268352868 +0000
@@ -1,4 +1,4 @@
-ARG SKANI_VER="0.3.1"
+ARG SKANI_VER="0.3.2"
 
 ## Builder ##
 FROM rust:1.90.0 AS builder
@@ -12,11 +12,11 @@
     chmod +x /root/.cargo/bin/skani
 
 ## App ##
-FROM ubuntu:jammy AS app
+FROM ubuntu:noble AS app
 
 ARG SKANI_VER
 
-LABEL base.image="ubuntu:jammy"
+LABEL base.image="ubuntu:noble"
 LABEL dockerfile.version="1"
 LABEL software="skani"
 LABEL software.version=${SKANI_VER}
@@ -25,6 +25,8 @@
 LABEL license="https://github.com/bluenote-1577/skani/blob/main/LICENSE"
 LABEL maintainer="Kutluhan Incekara"
 LABEL maintainer.email="kutluhan.incekara@ct.gov"
+LABEL maintainer2="Raheel Ahmed"
+LABEL maintainer2.email="raheelsyedahmed@gmail.com"
 
 # copy app from builder stage
 COPY --from=builder /root/.cargo/bin/skani /usr/local/bin/skani
@@ -40,8 +42,11 @@
 ## Test ##
 FROM app AS test
 
-RUN apt-get update && apt-get install -y wget &&\
-    wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-EC590.fasta &&\
+WORKDIR /test
+
+RUN apt-get update && apt-get install -y wget && \
+    apt-get autoclean && rm -rf /var/lib/apt/lists/* && \
+    wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-EC590.fasta && \
     wget https://github.com/bluenote-1577/skani/raw/v0.2.0/refs/e.coli-K12.fasta
 
 RUN skani dist e.coli-EC590.fasta e.coli-K12.fasta
\ No newline at end of file

@Kincekara Kincekara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks good

#14 [test 3/3] RUN skani dist e.coli-EC590.fasta e.coli-K12.fasta
#14 0.052 [00:00:00.000] (7f9471c21800) INFO   skani dist e.coli-EC590.fasta e.coli-K12.fasta
#14 0.095 [00:00:00.042] (7f9471c21800) INFO   Learned ANI mode detected. ANI may be adjusted according to a regression model trained on MAGs.
#14 0.095 [00:00:00.043] (7f9471c21800) INFO   Generating sketch time: 0.042976648
#14 0.105 [00:00:00.052] (7f9471c21800) INFO   ANI calculation time: 0.009690709
#14 0.105 Ref_file	Query_file	ANI	Align_fraction_ref	Align_fraction_query	Ref_name	Query_name
#14 0.105 e.coli-K12.fasta	e.coli-EC590.fasta	99.39	91.89	92.46	NC_007779.1 Escherichia coli str. K-12 substr. W3110, complete sequence	NZ_CP016182.2 Escherichia coli strain EC590 chromosome, complete genome
#14 DONE 0.1s

@Kincekara Kincekara merged commit e2cf39e into StaPH-B:master Jun 18, 2026
2 checks passed
@Kincekara

Copy link
Copy Markdown
Collaborator

Thank you for the update!
You can check the deployment status here: https://github.com/StaPH-B/docker-builds/actions/runs/27782824965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants