Skip to content

Clair3 2.0.1#1698

Open
RaheelSyedAhmed wants to merge 3 commits into
StaPH-B:masterfrom
RaheelSyedAhmed:clair3-2.0.1
Open

Clair3 2.0.1#1698
RaheelSyedAhmed wants to merge 3 commits into
StaPH-B:masterfrom
RaheelSyedAhmed:clair3-2.0.1

Conversation

@RaheelSyedAhmed

Copy link
Copy Markdown
Contributor

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

This PR includes an update to Clair3's build-files to include a directory for version 2.0.1. The Dockerfile is updated to use version 2.0.1 and the ARG has been moved to the top of the Dockerfile to avoid mismatching versions. Prior to this, it was present in both the app and build stage separately, and reviewers might have missed updating the CLAIR3_VER value in either stage. The main README.md has version 2.0.1 now listed in the versions dropdown. The program-specific README.md has been updated to include the new micromamba package versions and the new Clair3 models. The Program License remains at the same URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant