Clair3 2.0.1#1698
Open
RaheelSyedAhmed wants to merge 3 commits into
Open
Conversation
…f stages to avoid mismatches in version number.
… micromamba package versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)This PR includes an update to Clair3's build-files to include a directory for version 2.0.1. The Dockerfile is updated to use version 2.0.1 and the ARG has been moved to the top of the Dockerfile to avoid mismatching versions. Prior to this, it was present in both the app and build stage separately, and reviewers might have missed updating the CLAIR3_VER value in either stage. The main README.md has version 2.0.1 now listed in the versions dropdown. The program-specific README.md has been updated to include the new micromamba package versions and the new Clair3 models. The Program License remains at the same URL.