Skip to content

Prevent repeated alliance member count decrements - #55

Merged
SrMessiSOL merged 1 commit into
masterfrom
agent/prevent-repeated-alliance-member-decrement
Jul 11, 2026
Merged

SrMessiSOL merged 1 commit into
masterfrom
agent/prevent-repeated-alliance-member-decrement

Conversation

@SrMessiSOL

Copy link
Copy Markdown
Owner

What changed

  • reject alliance leave or expel operations for inactive membership records
  • decrement the alliance member count exactly once for active members
  • add regression coverage for active and inactive membership deactivation

Root cause

Alliance membership accounts remain allocated after leave or expulsion with role 0. The handlers did not require an active role, so the same account could repeatedly decrement member_count.

Impact

Prevents alliance capacity and membership accounting from being corrupted by replaying leave or expel operations.

Validation

  • cargo test --workspace --lib --locked
  • focused membership deactivation regression tests
  • git diff --check

@SrMessiSOL
SrMessiSOL marked this pull request as ready for review July 11, 2026 21:03
@SrMessiSOL
SrMessiSOL merged commit 029d6ef into master Jul 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant