Skip to content

fix: drive Instance parts nested inside Instance parts (SDK bump) #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naruto merged 4 commits into from
Sep 9, 2026
Merged

fix: drive Instance parts nested inside Instance parts (SDK bump) #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ed2902
update ss-sdk submodule
Naruto Sep 9, 2026
ebb64f2
fix(player): drive Instance children nested inside Instance parts
Naruto Sep 9, 2026
a7b87d7
update ss-sdk submodule
Naruto Sep 9, 2026
7e17530
chore: bump SDK to the landed instance-section fix
Naruto Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ss_player/SpriteStudio-SDK
Open in desktop
Submodule SpriteStudio-SDK updated from eab633 to c5ba33
7 changes: 6 additions & 1 deletion ss_player/ss_internal_player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,6 +1684,10 @@ void SsInternalPlayer::_drawAnimation(float frame_no, float delta_seconds, bool
}
}

for (uint32_t i = 0; i < _instance_children.size(); i++) {
if (_instance_children[i].player) _instance_children[i].player->setRootVisible(false);
}

// Per-frame draw-order counter: batch CIs and per-part CIs draw in the
// order they are emitted (rank order), not in CI-pool allocation order.
_draw_seq = 0;
Expand Down Expand Up @@ -2034,11 +2038,12 @@ void SsInternalPlayer::_drive_instance_slot(InstanceChildState& state,
child->play();
}

child->setRootVisible(false);
if (!r.visible) {
return;
}

child->_update_instance_children(r.child_frame_no, delta_seconds, r.child_looped);

_redraw_child_if_frame_changed(child, r.child_frame_no, delta_seconds, r.child_looped);
}

Expand Down
Loading