fix: land non-inheriting Skew (SDK bump) + correct part-tracking docs - #303
Merged
Conversation
added 3 commits
September 8, 2026 00:14
Skew is no longer folded into the world matrix, so the transform a SpriteStudioPartAttachment2D follows (and get_part_transform returns) carries no skew. Update the scripting guide (en/ja) accordingly: an attachment reflects position/rotation/scale and the mirror, but a part's skew — a non-inheriting per-part vertex deformation in SpriteStudio — is not part of the followed pose. Bump the SpriteStudio-SDK submodule to the matching runtime change (feat: apply Skew as a non-inheriting local-vertex deform). Claude-Session: https://claude.ai/code/session_01QgTZWEbMSX1xd87gC52guv
Comment-only change in ssruntime (SKEW_PROPAGATES doc); no behaviour change. Claude-Session: https://claude.ai/code/session_01QgTZWEbMSX1xd87gC52guv
Comment/lint-only changes in ssruntime (clippy 1.98 as_chunks / needless_late_init); no behaviour change. Claude-Session: https://claude.ai/code/session_01QgTZWEbMSX1xd87gC52guv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
SpriteStudio-SDKsubmodule to the non-inheriting-Skew runtime change (cri-middleware/SpriteStudio-SDK#398) and corrects the part-tracking documentation to match.Player-facing effect
Skew is no longer folded into the world matrix — SpriteStudio treats it as a per-part vertex deformation that does not inherit to children, and the runtime now applies it at the local-vertex stage. So:
SpriteStudioPartAttachment2Dfollows — andget_part_transform()returns — readsss_runtime_get_world_matrices, which is now skew-free. An attachment therefore reflects position / rotation / scale (and the mirror) but never a part's skew, consistent with skew being non-inheriting.No C++ change is needed on the player side — the part-tracker correction falls out of the runtime change automatically (it reads the world matrix, which no longer carries skew).
Changes
docs/en|ja/workflow/usage_scripting.md— the part-tracking accuracy notes no longer claim the followed transform includes skew; they explain that skew is a non-inheriting per-part deform and so is not part of the followed pose.ss_player/SpriteStudio-SDK— submodule bump to the change above.Depends on
https://claude.ai/code/session_01QgTZWEbMSX1xd87gC52guv