Skip to content

Spell out SpriteStudio #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naruto merged 1 commit into from
Aug 27, 2026
Merged

Spell out SpriteStudio #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ss_player/ss_internal_player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2109,7 +2109,7 @@ int SsInternalPlayer::_build_normal(const DrawFrame& f, int p_idx,
corner_rates[1] = pc->rt().rate();
corner_rates[2] = pc->lb().rate();
corner_rates[3] = pc->rb().rate();
// PartColor blend_type is 0..3 (Mix/Mul/Add/Sub). Higher SS7 values are
// PartColor blend_type is 0..3 (Mix/Mul/Add/Sub). Higher SpriteStudio values are
// GPU framebuffer blends, not PartColor formulas — clamp defensively.
blend_idx = (int)pc->blend_type();
if (blend_idx < 0 || blend_idx > 3) blend_idx = 0;
Expand Down Expand Up @@ -2306,7 +2306,7 @@ void SsInternalPlayer::_apply_per_part_uniforms(Ref<ShaderMaterial> mat, const f
void SsInternalPlayer::_apply_partcolor_material(RenderingServer* rs, RID ci, uint32_t shader_id_hash, ss::format::BlendType ss_blend) {
// Only Mix/Add/Sub/Mul are supported as GPU-side framebuffer blend modes
// here; any other batch blend_type falls back to Mix at the material level
// (the rest of the 12 SS7 blends are deferred — see ROADMAP). The
// (the rest of the 12 SpriteStudio blends are deferred — see ROADMAP). The
// per-vertex CUSTOM0 still drives PartColor compositing regardless.
ss::format::BlendType resolved = ss_blend;
switch (ss_blend) {
Expand Down
Loading