docs: link the shared runtime limitations instead of restating them - #238
Merged
Merged
Conversation
The four playback constraints in this page come from libssruntime and are duplicated word-for-word in SSPlayerForFlutter and SSPlayerForRenPy. They now live once in the documentation portal, which also covers the shared constraints this page never listed (embedded mode, unvalidated .ssab input). Keep a one-line summary of each so the page still reads on its own, and link out for the full explanation. Also restores the Contributor Covenant attribution in CODE_OF_CONDUCT.md, aligning it with SSPlayerForRenPy's copy. Kept in sync across docs/en/ and docs/ja/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The four playback constraints under Playback Feature Constraints come from
libssruntime, not from this plugin — and they are duplicated word-for-word in SSPlayerForFlutter and (partly) SSPlayerForRenPy. Four copies × two locales is four places to fix whenever the runtime's behavior is clarified.They now live once in the documentation portal, which additionally covers shared constraints this page never listed at all (embedded-mode caveats, unvalidated
.ssabinput, sequence playback still being unimplemented).What changed
dlink_enabledrequirement) is untouched — that is genuinely ours.CODE_OF_CONDUCT.md: restores the Contributor Covenant attribution section, aligning our copy with SSPlayerForRenPy's.Note
The portal link goes live when the portal is next published (deployment there is manual). Companion PRs do the same in SSPlayerForFlutter and SSPlayerForRenPy.