nipap-cli address list also shows the tags and attributes#1167
Open
jwalzer wants to merge 4 commits intoSpriteLink:masterfrom
Open
nipap-cli address list also shows the tags and attributes#1167jwalzer wants to merge 4 commits intoSpriteLink:masterfrom
jwalzer wants to merge 4 commits intoSpriteLink:masterfrom
Conversation
This patch makes it possible, to also see the tags and attributes per prefix, when doing an ```nipap-cli address list``` Feedback wanted
houndci-bot
reviewed
Jul 5, 2017
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| col_data['avps'] = '-' | ||
| if len(p.avps) > 0: | ||
| col_data['avps'] = ', '.join('{}:{}'.format(key,value) for key,value in sorted(p.avps.items())) | ||
|
|
nipap-cli/nipap_cli/nipap_cli.py
Outdated
|
|
||
| col_data['avps'] = '-' | ||
| if len(p.avps) > 0: | ||
| col_data['avps'] = ', '.join('{}:{}'.format(key,value) for key,value in sorted(p.avps.items())) |
There was a problem hiding this comment.
missing whitespace after ','
line too long (115 > 79 characters)
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| col_data['tags'] = '#%d' % len(p.tags) | ||
|
|
||
| col_data['tags'] = ','.join(p.tags) | ||
|
|
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| 'added': { 'title': 'Added' }, | ||
| 'alarm_priority': { 'title': 'Alarm Prio' }, | ||
| 'authoritative_source': { 'title': 'Auth source' }, | ||
| 'avps':{ 'title': 'extra-attributes'}, |
There was a problem hiding this comment.
missing whitespace after ':'
whitespace after '{'
This commit is for cleanup of the nits found when automatically checking the Merge-Request
houndci-bot
reviewed
Jul 5, 2017
|
|
||
| col_data['avps'] = '-' | ||
| if len(p.avps) > 0: | ||
| col_data['avps'] = ','.join('{}:{}'.format(key, value) for key, value in sorted(p.avps.items())) |
There was a problem hiding this comment.
line too long (116 > 79 characters)
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| col_data['tags'] = ','.join(p.tags) | ||
|
|
||
| col_data['avps'] = '-' | ||
| if len(p.avps) > 0: |
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| col_data['tags'] = '-' | ||
| if len(p.tags) > 0: | ||
| col_data['tags'] = '#%d' % len(p.tags) | ||
| if len(p.tags) > 0: |
nipap-cli/nipap_cli/nipap_cli.py
Outdated
| 'added': { 'title': 'Added' }, | ||
| 'alarm_priority': { 'title': 'Alarm Prio' }, | ||
| 'authoritative_source': { 'title': 'Auth source' }, | ||
| 'avps':{ 'title': 'Extra-Attributes' }, |
There was a problem hiding this comment.
missing whitespace after ':'
whitespace after '{'
whitespace before '}'
houndci-bot
reviewed
Jul 5, 2017
|
|
||
| col_data['avps'] = '-' | ||
| if len(p.avps) > 0: | ||
| col_data['avps'] = ','.join('{}:{}'.format(key, value) for key, value in sorted(p.avps.items())) |
There was a problem hiding this comment.
line too long (116 > 79 characters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes it possible, to also see the tags and attributes per prefix, when doing an
nipap-cli address listFeedback wanted