Skip to content

refactor: TaskId를 common에서 task BC로 이동 (#27) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjoon merged 1 commit into from
Mar 7, 2026
Merged

refactor: TaskId를 common에서 task BC로 이동 (#27) #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/layers/domain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ value class TaskTitle(val value: String) {
}
```

BC간 공유 VO(MemberId, TaskId 등)는 `common/domain/`에 위치합니다.
BC간 공유 VO(MemberId, GoalId 등)는 `common/domain/`에 위치합니다.

### Command

Expand Down
10 changes: 10 additions & 0 deletions docs/plan/#27-taskid-location-fix/checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# TaskId 위치 수정 검증 체크리스트

## 필수 항목
- [x] 아키텍처 원칙 준수 (common/domain에는 2개 이상 BC에서 사용하는 VO만 배치)
- [x] 레이어 의존성 규칙 위반 없음
- [x] 모든 테스트 통과
- [x] 기존 테스트 깨지지 않음
- [x] common/domain/TaskId.kt 삭제됨
- [x] task/domain/model/TaskId.kt 생성됨
- [x] 모든 import 경로 변경됨
11 changes: 11 additions & 0 deletions docs/plan/#27-taskid-location-fix/plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# TaskId 위치 수정 계획

> Issue: #27

## 단계

- [x] 1단계: TaskId를 task/domain/model/로 이동
- [x] 2단계: common/domain/TaskId.kt 삭제
- [x] 3단계: 모든 import 경로를 task.domain.model.TaskId로 변경
- [x] 4단계: domain.md 문서에서 TaskId 공유 VO 언급 제거
- [x] 5단계: 테스트 통과 확인
1 change: 0 additions & 1 deletion src/main/kotlin/kr/io/team/loop/task/domain/model/Task.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package kr.io.team.loop.task.domain.model
import kotlinx.datetime.LocalDate
import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId
import java.time.Instant

data class Task(
Expand Down
1 change: 0 additions & 1 deletion src/main/kotlin/kr/io/team/loop/task/domain/model/TaskCommand.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package kr.io.team.loop.task.domain.model
import kotlinx.datetime.LocalDate
import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId

sealed interface TaskCommand {
data class Create(
Expand Down
2 changes: 1 addition & 1 deletion ...n/kr/io/team/loop/common/domain/TaskId.kt → .../io/team/loop/task/domain/model/TaskId.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package kr.io.team.loop.common.domain
package kr.io.team.loop.task.domain.model

import kr.io.team.loop.common.domain.exception.InvalidInputException

Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/kr/io/team/loop/task/domain/repository/TaskRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package kr.io.team.loop.task.domain.repository

import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.TaskId
import kr.io.team.loop.task.domain.model.Task
import kr.io.team.loop.task.domain.model.TaskCommand
import kr.io.team.loop.task.domain.model.TaskId
import kr.io.team.loop.task.domain.model.TaskQuery

interface TaskRepository {
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/kr/io/team/loop/task/infrastructure/persistence/ExposedTaskRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ package kr.io.team.loop.task.infrastructure.persistence

import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId
import kr.io.team.loop.task.domain.model.Task
import kr.io.team.loop.task.domain.model.TaskCommand
import kr.io.team.loop.task.domain.model.TaskId
import kr.io.team.loop.task.domain.model.TaskQuery
import kr.io.team.loop.task.domain.model.TaskStatus
import kr.io.team.loop.task.domain.model.TaskTitle
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/kr/io/team/loop/task/presentation/datafetcher/TaskDataFetcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import kr.io.team.loop.codegen.types.UpdateTaskInput
import kr.io.team.loop.common.config.Authorize
import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId
import kr.io.team.loop.task.application.service.TaskService
import kr.io.team.loop.task.domain.model.Task
import kr.io.team.loop.task.domain.model.TaskCommand
import kr.io.team.loop.task.domain.model.TaskId
import kr.io.team.loop.task.domain.model.TaskQuery
import kr.io.team.loop.task.domain.model.TaskStatus
import kr.io.team.loop.task.domain.model.TaskTitle
Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/kr/io/team/loop/task/application/service/TaskServiceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ import io.mockk.verify
import kotlinx.datetime.LocalDate
import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId
import kr.io.team.loop.common.domain.exception.AccessDeniedException
import kr.io.team.loop.common.domain.exception.EntityNotFoundException
import kr.io.team.loop.task.domain.model.Task
import kr.io.team.loop.task.domain.model.TaskCommand
import kr.io.team.loop.task.domain.model.TaskId
import kr.io.team.loop.task.domain.model.TaskQuery
import kr.io.team.loop.task.domain.model.TaskStatus
import kr.io.team.loop.task.domain.model.TaskTitle
Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/kr/io/team/loop/task/domain/model/TaskTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import io.kotest.matchers.shouldBe
import kotlinx.datetime.LocalDate
import kr.io.team.loop.common.domain.GoalId
import kr.io.team.loop.common.domain.MemberId
import kr.io.team.loop.common.domain.TaskId
import kr.io.team.loop.task.domain.model.TaskId
import java.time.Instant

class TaskTest :
Expand Down