Repository navigation
fix(map): bubbles and header counts follow active filters - #60
Merged
Merged
Conversation
…Naver grouped counts that ignore filters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Map bubbles and header counts kept showing homes that active filters exclude.
Root cause
mapLayersForFilters(client) mixed several sources of truth:Naver 7,418but bubbles/“on map” summed to 68).naver:cluster:) bypassfilterListingsentirely. The Naver cluster API accepts type, trade type, price, size and building age, but not text, floor, listing date, foreigner or photos, so with those filters the counts were presented as filtered but were not.stats; Ask-picks mode kept live-search counts while drawing only picks; list total used the same stats.Fix
grouped) and flags them (unfiltered) when an active filter the Naver cluster API cannot take is on; clusters carryunfilteredCount/groupedCount; stats carrynaverUnfiltered.≈for Naver.layerSourceCounts).