Repository navigation
Fix language URL/SSR, Korean Ask names, narrow/short layouts, listing polish - #58
Merged
Merged
Conversation
…similar chip label, regenerate on language change
…lang/title/h1 follow language, lang-aware links
…for list panel, similar aria, faster translate
…eader wrap, measured carousel offset for attribution, short/tiny viewports
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the real-browser smoke test of production.
1. Language in the URL / SSR
?lang=ko(removed for English), keeping other params; also applied on load when only localStorage says Korean. Map URL sync, listing links, listing share/copy links, "back to map" links and the header "Copy link" keep it.ziggy_langcookie +middleware.ts(?lang=beats cookie): root layout sets<html lang>server-side;/metadata (title/description/OG), h1 and intro render in the right language on a bare/too. h1/intro are a small client component so they also follow in-page switches.2. Korean Ask
ko) and districts (gu);displayPlace(name, lang)is used in chips, summaries, reasons, commute labels/cards and AI prompt chips, so names are consistent.englishDistrictpreferred the longest match (서울특별시 beat 성동구); now a 구 beats a city, and a neighbourhood whose district contradicts the address is dropped.3. Layout at zoom / short viewports
md(768px width). 200% zoom of a ~1920 window is ~960 css px, so the 40% panel was ~380px. Nowdesk= width ≥1024 AND height ≥540; everything else uses the stacked layout. Addedshort/tiny/narrowscreens.4. Smaller
?preview=(Back closes it).Verified: tsc, eslint (0 errors), vitest (445, live excluded),
next build, headless screenshots 1440x900 / 512x320 / 390x844 / 640x400 / 768x400 / 1024x500 in EN and KO.