feat(browse): add text and JSON viewers, list non-tabular files#22
Merged
Conversation
The browse subcommand previously hid non-tabular files entirely. List every entry instead and route by kind: tabular files (csv/tsv/parquet and JSON arrays) open in the existing DataFrame viewer, plain text and non-array JSON open in a new text viewer with scroll, search, line numbers, word wrap and pretty-printed JSON. Binary files render dimmed and surface a status message on Enter rather than failing silently. JSON routing peeks the root byte to decide: arrays go through polars, objects/scalars go to the text viewer (polars otherwise loads them as 1-row all-null DataFrames, which the original Err fall-through couldn't detect). Adds Suite Z to qa.sh covering the new keybindings and the JSON/binary routing. Also fixes two pre-existing QA assertions that referenced an old plot-mode shortcut bar label. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browse subcommand previously hid non-tabular files entirely. List every entry instead and route by kind: tabular files (csv/tsv/parquet and JSON arrays) open in the existing DataFrame viewer, plain text and non-array JSON open in a new text viewer with scroll, search, line numbers, word wrap and pretty-printed JSON. Binary files render dimmed and surface a status message on Enter rather than failing silently.
JSON routing peeks the root byte to decide: arrays go through polars, objects/scalars go to the text viewer (polars otherwise loads them as 1-row all-null DataFrames, which the original Err fall-through couldn't detect).
Adds Suite Z to qa.sh covering the new keybindings and the JSON/binary routing. Also fixes two pre-existing QA assertions that referenced an old plot-mode shortcut bar label.