Skip to content

Confirm time (when) specs are re-enabled and document existing fix reference#310

Closed
Copilot wants to merge 1 commit into
masterfrom
copilot/re-enable-time-validation-tests
Closed

Confirm time (when) specs are re-enabled and document existing fix reference#310
Copilot wants to merge 1 commit into
masterfrom
copilot/re-enable-time-validation-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

The issue tracked re-enabling tests/time specs that were previously class-level disabled pending Spine Time migration to the new Placeholder API. This PR confirms the tests are already enabled in-repo and points to the existing change that addressed it.

  • Current state verification

    • TimestampWhenSpec and TemporalWhenSpec no longer have class-level @Disabled.
    • No code edits were required in this branch.
  • Existing fix linkage

  • Relevant code state (already present)

    @DisplayName("If used with Protobuf `Timestamp`, `(when)` constraint should")
    internal class TimestampWhenSpec { ... }
    
    @DisplayName("If used with `Temporal`, `(when)` constraint should")
    internal class TemporalWhenSpec { ... }

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.jetbrains.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=1024m -XX:+UseParallelGC -Xmx4096m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI self-assigned this May 22, 2026
Copilot AI review requested due to automatic review settings May 22, 2026 13:22
Copilot AI review requested due to automatic review settings May 22, 2026 13:22
Copilot AI linked an issue May 22, 2026 that may be closed by this pull request
3 tasks
Copilot AI changed the title [WIP] Re-enable time validation tests after API migration Confirm time (when) specs are re-enabled and document existing fix reference May 22, 2026
Copilot AI requested a review from alexander-yevsyukov May 22, 2026 13:28
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review May 22, 2026 13:55
Copilot AI review requested due to automatic review settings May 22, 2026 13:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexander-yevsyukov alexander-yevsyukov deleted the copilot/re-enable-time-validation-tests branch May 22, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable time validation tests after Spine Time migrates to the new Placeholder API

3 participants