Adopt new TemplateString and Placeholder API#196
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates validation placeholder usage to newer io.spine.string/StandardPlaceholder APIs, refreshes dependency versions and Gradle wrapper metadata, and reorganizes generated dependency reports under docs/dependencies.
Changes:
- Migrates
(when)andLocalDateValidatorplaceholder handling to new placeholder types. - Updates build/report generation paths and dependency versions, including Gradle wrapper metadata.
- Adds/updates agent documentation for version and Gradle bump workflows.
Reviewed changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenOption.kt |
Uses StandardPlaceholder values for supported (when) placeholders. |
validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenGenerator.kt |
Generates placeholder maps with io.spine.string.Placeholder. |
time/src/test/java/io/spine/time/validation/WhenTest.java |
Updates imports and disables the (when) test class. |
time/src/main/kotlin/io/spine/time/validation/LocalDateValidator.kt |
Migrates runtime placeholder template construction. |
tests/build.gradle.kts |
Adds Base to compiler configuration for new template classes. |
gradlew.bat |
Updates Windows Gradle wrapper script behavior. |
gradlew |
Updates wrapper template reference comment. |
gradle/wrapper/gradle-wrapper.properties |
Bumps Gradle distribution and wrapper retry properties. |
docs/dependencies/pom.xml |
Adds generated dependency POM under docs. |
CLAUDE.md |
Corrects agent documentation path. |
buildSrc/src/test/kotlin/io/spine/gradle/report/license/DependencyReportOutputTest.kt |
Adds tests for dependency report output locations. |
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/PomGenerator.kt |
Writes generated POM under docs/dependencies. |
buildSrc/src/main/kotlin/io/spine/gradle/report/license/Paths.kt |
Centralizes dependency report output paths. |
buildSrc/src/main/kotlin/io/spine/gradle/report/license/LicenseReporter.kt |
Writes merged license report under docs/dependencies. |
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt |
Updates Validation dependency version. |
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt |
Updates Core JVM compiler dependency versions. |
buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt |
Updates Base dependency versions. |
.gitignore |
Ignores Claude working files. |
.github/workflows/ensure-reports-updated.yml |
Renames dependency report check step. |
.agents/version-policy.md |
Replaces detailed local version instructions with policy/skill references. |
.agents/skills/writer/SKILL.md |
Adds documentation quoting guidance. |
.agents/skills/bump-version/SKILL.md |
Adds version bump agent skill. |
.agents/skills/bump-version/agents/openai.yaml |
Adds OpenAI metadata for version bump skill. |
.agents/skills/bump-gradle/SKILL.md |
Adds Gradle wrapper bump agent skill. |
.agents/skills/bump-gradle/agents/openai.yaml |
Adds OpenAI metadata for Gradle bump skill. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TemplateString and Placeholder API
Also: * Enable previously disabled test.
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM, hopefully the CI check is fixed by this PR I have just approved as well.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage 83.88% 83.88%
Complexity 304 304
=========================================
Files 60 60
Lines 1086 1086
Branches 46 46
=========================================
Hits 911 911
Misses 165 165
Partials 10 10 🚀 New features to boost your workflow:
|
This PR migrates Spine Time to newest version of Base, Validation, and CoreJvm Compiler. This brings new
TemplateStringAPI to which this PR migrates.