Skip to content

Adopt new TemplateString and Placeholder API#196

Merged
alexander-yevsyukov merged 14 commits into
masterfrom
new-placeholders
May 19, 2026
Merged

Adopt new TemplateString and Placeholder API#196
alexander-yevsyukov merged 14 commits into
masterfrom
new-placeholders

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Contributor

@alexander-yevsyukov alexander-yevsyukov commented May 18, 2026

This PR migrates Spine Time to newest version of Base, Validation, and CoreJvm Compiler. This brings new TemplateString API to which this PR migrates.

Copilot AI review requested due to automatic review settings May 18, 2026 20:33
@alexander-yevsyukov alexander-yevsyukov moved this to 🏗 In progress in v2.0 May 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates validation placeholder usage to newer io.spine.string/StandardPlaceholder APIs, refreshes dependency versions and Gradle wrapper metadata, and reorganizes generated dependency reports under docs/dependencies.

Changes:

  • Migrates (when) and LocalDateValidator placeholder handling to new placeholder types.
  • Updates build/report generation paths and dependency versions, including Gradle wrapper metadata.
  • Adds/updates agent documentation for version and Gradle bump workflows.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenOption.kt Uses StandardPlaceholder values for supported (when) placeholders.
validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenGenerator.kt Generates placeholder maps with io.spine.string.Placeholder.
time/src/test/java/io/spine/time/validation/WhenTest.java Updates imports and disables the (when) test class.
time/src/main/kotlin/io/spine/time/validation/LocalDateValidator.kt Migrates runtime placeholder template construction.
tests/build.gradle.kts Adds Base to compiler configuration for new template classes.
gradlew.bat Updates Windows Gradle wrapper script behavior.
gradlew Updates wrapper template reference comment.
gradle/wrapper/gradle-wrapper.properties Bumps Gradle distribution and wrapper retry properties.
docs/dependencies/pom.xml Adds generated dependency POM under docs.
CLAUDE.md Corrects agent documentation path.
buildSrc/src/test/kotlin/io/spine/gradle/report/license/DependencyReportOutputTest.kt Adds tests for dependency report output locations.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/PomGenerator.kt Writes generated POM under docs/dependencies.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/Paths.kt Centralizes dependency report output paths.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/LicenseReporter.kt Writes merged license report under docs/dependencies.
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Updates Validation dependency version.
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt Updates Core JVM compiler dependency versions.
buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt Updates Base dependency versions.
.gitignore Ignores Claude working files.
.github/workflows/ensure-reports-updated.yml Renames dependency report check step.
.agents/version-policy.md Replaces detailed local version instructions with policy/skill references.
.agents/skills/writer/SKILL.md Adds documentation quoting guidance.
.agents/skills/bump-version/SKILL.md Adds version bump agent skill.
.agents/skills/bump-version/agents/openai.yaml Adds OpenAI metadata for version bump skill.
.agents/skills/bump-gradle/SKILL.md Adds Gradle wrapper bump agent skill.
.agents/skills/bump-gradle/agents/openai.yaml Adds OpenAI metadata for Gradle bump skill.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread time/src/test/java/io/spine/time/validation/WhenTest.java Outdated
Comment thread gradlew.bat
Comment thread gradlew.bat
@alexander-yevsyukov alexander-yevsyukov changed the title New placeholders Adopt new TemplateString and Placeholder API May 18, 2026
Also:
 * Enable previously disabled test.
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review May 18, 2026 21:13
Copilot AI review requested due to automatic review settings May 18, 2026 21:13
@alexander-yevsyukov alexander-yevsyukov self-assigned this May 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 31 changed files in this pull request and generated 1 comment.

Comment thread buildSrc/src/main/kotlin/io/spine/gradle/report/license/Paths.kt
Copy link
Copy Markdown
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov LGTM, hopefully the CI check is fixed by this PR I have just approved as well.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.88%. Comparing base (f8d6d30) to head (f2d4b56).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage     83.88%   83.88%           
  Complexity      304      304           
=========================================
  Files            60       60           
  Lines          1086     1086           
  Branches         46       46           
=========================================
  Hits            911      911           
  Misses          165      165           
  Partials         10       10           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov merged commit 51209b3 into master May 19, 2026
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the new-placeholders branch May 19, 2026 15:17
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in v2.0 May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants