Add gradle-review skill and related task documents#671
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78d7f41faa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`rg --type kt` fails with `unrecognized file type: kt`; the built-in type name is `kotlin` (covers `*.kt` and `*.kts`). Addresses Codex review comment on PR #671. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new repo-level agent skill, gradle-review, to review Gradle-related changes against Spine task conventions and ingested Gradle best-practices notes. It also adds a shared SpineTaskGroup constant for consistent task grouping and records follow-up work as task-plan documents.
Changes:
- Added the
gradle-reviewskill with Spine task conventions and a version-pinned “tasks best practices” reference. - Introduced
SpineTaskGroup.nameconstant inbuildSrcfor consistent Gradle task grouping. - Added several
.agents/tasks/*.mdplans capturing follow-up Gradle review and build caching work.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| buildSrc/src/main/kotlin/io/spine/gradle/SpineTaskGroup.kt | Adds a shared constant for the Spine Gradle task group name. |
| .agents/tasks/spine-task-group-constant.md | Task plan documenting the introduction/migration strategy for the task-group constant. |
| .agents/tasks/improve-test-coverage.md | Task plan draft for a future coverage-analysis/test-generation skill. |
| .agents/tasks/gradle-caching-plan.md | Adds an org-wide Gradle caching improvement plan (missing task frontmatter). |
| .agents/tasks/buildsrc-gradle-review-findings.md | Captures /gradle-review findings for later remediation in a separate PR. |
| .agents/skills/gradle-review/spine-task-conventions.md | Defines Spine’s task metadata conventions (group/description) and examples. |
| .agents/skills/gradle-review/SKILL.md | Defines the gradle-review skill scope and procedure. |
| .agents/skills/gradle-review/practices/tasks.md | Ingested Gradle best-practices notes for tasks (currently linked to /current/). |
| .agents/skills/gradle-review/practices/README.md | Index + ingest procedure for Gradle best-practices notes. |
| .agents/_TOC.md | Adds the gradle-review skill to the .agents TOC. |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- Pin Gradle docs URLs to `/9.5.1/` everywhere they referenced `/current/`, matching the `gradle-version: 9.5.1` pin in `practices/tasks.md`. (4 sites: SKILL.md footnote, practices/README.md table, practices/tasks.md source + footnote.) - Update `spine-task-conventions.md` examples to use the `SpineTaskGroup.name` constant introduced in this PR rather than the bare `"spine"` literal. - Add the required YAML frontmatter (`slug`, `branch`, `owner`, `status`, `started`) to `.agents/tasks/gradle-caching-plan.md`. - Drop the empty `related-memories:` line from `improve-test-coverage.md` so parsers do not treat it as null. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
armiol
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines the
gradle-reviewskill. The skill was applied to this repository and its findings were added as a task item. Additionally, a task on improving Gradle caching was added. Actual work on the tasks will be performed in separate PRs.The
gradlew-reviewskill has an ability to improve itself when a new version of Gradle is released (user-initiated) or when we decide that a new aspect of Grade's best practices should be applied (obviously, user-initiated too). The skill keeps the references to the Gradle specs in its meta-data.