Tools group and package#6
Conversation
Also: * Use `io.spine.annotation.Modified` instead of `javax.annotation.Generated`.
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general.
There are a few things to address, though:
-
Please update the
README.mdwith the links to this repository. They are now pointing to ProtoData. -
There are several occasions of ProtoData still mentioned in the docs (cannot comment on the lines, as they aren't changed in this PR):
io.spine.tools.compiler.context.Member.kt,io.spine.tools.compiler.ast.TypeExts.kt,io.spine.tools.compiler.plugin.ConfigurationError,io.spine.tools.compiler.render.Renderer.kt,io.spine.tools.compiler.settings.LoadsSettings.kt,io.spine.tools.compiler.settings.SettingsDirectory.kt,io.spine.tools.compiler.settings.WithSettings.kt
And also, io.spine.tools.compiler.plugin.Policy.kt and io.spine.tools.compiler.plugin.View.kt reference the wrong Proto file via .../protodata/... path.
These I have found in Kotlin files. There are many more in .proto files which you can identify by searching for "ProtoData" in case-insensitive way.
|
@alexander-yevsyukov I only point out these things because I have initially encountered a wrong reference to the We can do that in the following PR anyway. |
... in favor of `io.spine.format.Format`.
Also: * Fix the directory name in stub proto file.
Also: * Fix package references.
|
@alexander-yevsyukov One more thing left here. |
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov please see my comment.
Other than that, LGTM.
|
@alexander-yevsyukov how come the PR merged automatically after it has been approved? |
|
@alexander-yevsyukov FYI, I have just disabled this behavior.
Please take my comment into account next time. |

This PR moves the
compilerpackage underio.spine.tools, and allocates the Spine Compiler artifacts under theio.spine.toolsMaven group.Other notable changes
io.spine.annotation.Modifiedis used instead ofjavax.annotation.Generatedbecause:com.google.protobuf.Generatedannotation.io.spine.tools.compiler.util.Formatwas deprecated in favor ofio.spine.format.Format.8.14.2.