Decrease dialog's height if the description field is empty#117
Merged
Conversation
dpikhulya
approved these changes
Apr 18, 2025
Contributor
dpikhulya
left a comment
dpikhulya
left a comment
There was a problem hiding this comment.
@Oleg-Melnik LGTM with some notes below.
| */ | ||
| public suspend fun showConfirmation(): Boolean { | ||
| if (description.isBlank() && height == DefaultDialogHeight) { | ||
| height -= ReservedDescriptionHeight |
Contributor
There was a problem hiding this comment.
As discussed, please also create an issue to try to implement some automatic size detection mechanisms for dialogs in general, and place a respective TODO here. This way, it will be clear that this is an intermediate approach.
| */ | ||
| private suspend fun show(): String? { | ||
| if (description.isBlank() && height == DefaultDialogHeight) { | ||
| height -= ReservedDescriptionHeight |
Contributor
There was a problem hiding this comment.
The same thing — add a TODO for a future more sound solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the height of the
ConfirmationDialogandInputTextDialogcomponents when the description field is not provided by the user and the dialog height remains at its default value.