Repository navigation
Conversation
ZakayZ
changed the title
apBUSampK
approved these changes
Oct 29, 2026
apBUSampK
left a comment
apBUSampK
left a comment
Member
There was a problem hiding this comment.
I don't particularly like that we began splitting our metadata between the map and the string. Probably should rethink this, when we migrate to YAML for configuration.
LGTM
apBUSampK
merged commit Oct 29, 2026
a907a01
into
Spectator-matter-group-INR-RAS:main
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericFactory passes configuration metadata to filters that accept it, while preserving default construction for existing filters. Regression tests cover constructor selection and configuration passed through XML.
Validation: Release build with Unix Makefiles, CTest 19/19 passed, and git diff --check passed.
The pre-existing uninstall target on main still prevents Ninja from parsing the generated build file.