ShaderTransformer: Fix integer texture attributes - #140
Merged
Conversation
Minecraft uses integer formats (namely 16-bit signed integers) for its secondary (light and overlay) textures in all its `VertexFormat`s. Previously the ShaderTransformer, used to convert legacy OpenGL shaders to more modern OpenGL, used to use the GLSL type `vec2` for all texture attributes. This resulted in broken values being delivered to the shader on modern versions (presumably because they're trying to interpret the bytes representing integer values as floating point values). This commit fixes the issue by using `ivec2` where the provided VertexFormat contains an integer type for the attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minecraft uses integer formats (namely 16-bit signed integers) for its secondary (light and overlay) textures in all its
VertexFormats.Previously the ShaderTransformer, used to convert legacy OpenGL shaders to more modern OpenGL, used to use the GLSL type
vec2for all texture attributes. This resulted in broken values being delivered to the shader on modern versions (presumably because they're trying to interpret the bytes representing integer values as floating point values).This commit fixes the issue by using
ivec2where the provided VertexFormat contains an integer type for the attribute.