URenderPipeline: Add missing DepthTest functions - #133
Merged
Conversation
These weren't implemented originally because Minecraft's enum didn't have them. We did need `ALWAYS` though, so a hack was implemented for that one. Minecraft did add support for all functions in 26.1. And given we already have a working workaround for older versions, there's no reason `URenderPipeline` shouldn't support all options. And we'll soon have a pressing use case for `GreaterOrEqual` because Minecraft 26.2 uses reversed Z, so any pipeline using `LessOrEqual` needs to use `GreaterOrEqual` instead.
Johni0702
force-pushed
the
feature/add-more-depthtest-functions
branch
from
April 28, 2026 16:54
15ce35a to
d40a407
Compare
Traben-0
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These weren't implemented originally because Minecraft's enum didn't have them.
We did need
ALWAYSthough, so a hack was implemented for that one.Minecraft did add support for all functions in 26.1. And given we already have a working workaround for older versions, there's no reason
URenderPipelineshouldn't support all options.And we'll soon have a pressing use case for
GreaterOrEqualbecause Minecraft 26.2 uses reversed Z, so any pipeline usingLessOrEqualneeds to useGreaterOrEqualinstead.