Skip to content

BasicFontRenderer: Fix scaling #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johni0702 merged 1 commit into from
Aug 3, 2026
Merged

BasicFontRenderer: Fix scaling #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/main/kotlin/gg/essential/elementa/font/BasicFontRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ class BasicFontRenderer(
shadow: Boolean,
shadowColor: Color?
) {
val scaledPointSize = scale * regularFontInfo.atlas.size

if (shadow) {
drawStringNow(
vertexConsumer,
Expand All @@ -148,7 +146,7 @@ class BasicFontRenderer(
),
x + 1,
y + 1,
scaledPointSize,
scale,
)
}
drawStringNow(
Expand All @@ -158,7 +156,7 @@ class BasicFontRenderer(
color,
x,
y,
scaledPointSize,
scale,
)
}

Expand All @@ -181,8 +179,10 @@ class BasicFontRenderer(
color: Color,
x: Float,
y: Float,
originalPointSize: Float
scale: Float,
) {
val scaledPointSize = scale * regularFontInfo.atlas.size

var currentX = x
var i = 0
while (i < string.length) {
Expand All @@ -204,22 +204,22 @@ class BasicFontRenderer(
val planeBounds = glyph.planeBounds

if (planeBounds != null) {
val width = (planeBounds.r - planeBounds.l) * originalPointSize
val height = (planeBounds.t - planeBounds.b) * originalPointSize
val width = (planeBounds.r - planeBounds.l) * scaledPointSize
val height = (planeBounds.t - planeBounds.b) * scaledPointSize

drawGlyph(
vertexConsumer,
matrixStack,
glyph,
color,
currentX,
y + regularFontInfo.atlas.baseCharHeight - planeBounds.t * originalPointSize,
y + regularFontInfo.atlas.baseCharHeight * scale - planeBounds.t * scaledPointSize,
width,
height
)
}

currentX += computeAdvance(regularFontInfo, glyph) * originalPointSize
currentX += computeAdvance(regularFontInfo, glyph) * scaledPointSize
i++
}

Expand Down
Loading