AnimationComponent: Unwrap old constraint if complete - #181
Merged
Conversation
This fixes stack overflow errors (and increasingly worse performance) when (even short-lived) animations are stacked on top of each other. The current animation system naturally stacks multiple animation constraints on top of each other, it however only unwraps completed animation constraints when the top-most one is completed (in `AnimatingConstraints.updateCompletion`). By e.g. continuously scrolling a ScrollComponent up and down via its scrollbar, such that there's no 0.1s without new input, this animation stack will there grow indefinitely and eventually result in a StackOverflowError (on my machine after ~40s, slowly halfing FPS in the process). This commit fixes this issue by having each animation constraint internally unwrap its `oldConstraint` when that is done, thereby keeping the effective animation stack flat. The `oldConstraint` property itself is not modified, since it is public API.
SamPlummer
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes stack overflow errors (and increasingly worse performance) when (even short-lived) animations are stacked on top of each other.
The current animation system naturally stacks multiple animation constraints on top of each other, it however only unwraps completed animation constraints when the top-most one is completed (in
AnimatingConstraints.updateCompletion). By e.g. continuously scrolling a ScrollComponent up and down via its scrollbar, such that there's no 0.1s without new input, this animation stack will there grow indefinitely and eventually result in a StackOverflowError (on my machine after ~40s, slowly halfing FPS in the process).This commit fixes this issue by having each animation constraint internally unwrap its
oldConstraintwhen that is done, thereby keeping the effective animation stack flat. TheoldConstraintproperty itself is not modified, since it is public API.