Repository navigation
ON HOLD - Momentum#1747 adaptive custom rules: trigger wording - #873
Closed
dkoerichbird wants to merge 2 commits into
Closed
dkoerichbird wants to merge 2 commits into
dkoerichbird wants to merge 2 commits into
Conversation
…nces The page said more than N; a rule fires on the Nth occurrence within the period, locally and cluster-wide. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Doug Koerich <douglas.koerich@bird.com>
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dkoerichbird
changed the title
… acts like 1 The rules appendix said "when the rate is crossed"; it now matches the reworded adaptive_rules.lua comment, and the custom rules page says a count of 1 per period fires on every occurrence. Signed-off-by: Doug Koerich <douglas.koerich@bird.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Moved to SparkPost/momentum-docs#4 as part of SparkPost/Momentum#1765. The Momentum docs now live in that repository, so this PR is closed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the decided behaviour of an adaptive
triggerof"C/S": it fires on the Cth occurrence within S seconds, and1/Sacts like1.Depends on SparkPost/Momentum#1759 (the fix for SparkPost/Momentum#1747); keep as draft until it merges.
🤖 Generated with Claude Code