Repository navigation
Conversation
…ash_algorithm options
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dkoerichbird
requested changes
Oct 8, 2026
| | `error` | Errors, such as a `sign()` whose key cannot be read. **Default.** | | ||
| | `warning` | Adds a key lookup that fails or returns a resolver error other than NXDOMAIN; a verification that stops at a limit; a `sign()` that signs with `f=exploded` although an earlier signature asked for `f=donotexplode`; and a `sign()` that signs over two fields claiming the same `i=` or the same `m=`. | | ||
| | `info` | Adds, for each key looked up in DNS, a line naming the TXT record and a line with the answer; the verdict of each `verify()` with its reason (for example `body_hash_mismatch`); a line for each `sign()` that adds fields; and each refusal by `sign()`, including one it then signs over, bridges or skips. | | ||
| | `debug` | Nothing beyond `info`. | |
Contributor
There was a problem hiding this comment.
Is it worth mentioning debug, then?
Contributor
Author
There was a problem hiding this comment.
Fixed in 101f459. The table now lists only the levels that add lines for DKIM2.
dkoerichbird
approved these changes
Oct 8, 2026
balupillai
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents two Momentum changes to the experimental DKIM2 module:
on_recipe_key_caseandon_bad_hash_algorithmoptions.verify()result, Authentication-Results,sign()failures and chain breaks,require_recipeandreject_body_redaction, key checks, option type checks and logging.The 5.3.1 changelog gets a row for each. It also gets the rows for SparkPost/Momentum#1678 and #1683.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only; no runtime code changes, though it describes breaking DKIM2 Lua API and wire-compat changes operators must plan for on upgrade.
Overview
Updates Momentum DKIM2 and 5.3.1 docs to match draft
-06and the 5.3.1 signing/verification engine (I-1651, I-1705), plus SMTP relay fixes (I-1678, I-1683) in the changelog.DKIM2 reference pages (
dkim2/*.md) are rewritten around breaking operator/API changes:verify()now cryptographically checks every hop with a newresultshape (problems,ar, per-sigsets, renamed reason codes,dsn_prohibited);ar_clauses()is driven byresult.arwith draft-stylereason=and quotedheader.s/mf/rt. Signing documentsrequire_recipe(replacingallow_missing_recipe), default{"b":null}when content changed without a recipe, third-valuerefusalon failedsign(), stricter chain-break rules, and Ed25519p=/ RSA size /sig_partialbehavior. Overview drops several old “known limitations” (e.g. Received-SPF, highest-only crypto) and points debug/reasons to the updated verify page.Adds
content/momentum/changelog/5/5-3-1.mdand links it fromnavigation.ymland the 5.x changelog index.Reviewed by Cursor Bugbot for commit 101f459. Bugbot is set up for automated code reviews on this repo. Configure here.