use step interpolation for chart fidelity, linear for PV only#4
Merged
cayossarian merged 2 commits intomainfrom Apr 5, 2026
Merged
use step interpolation for chart fidelity, linear for PV only#4cayossarian merged 2 commits intomainfrom
cayossarian merged 2 commits intomainfrom
Conversation
Circuit graphs previously used linear interpolation between data points, creating misleading diagonal ramps for instantaneous value changes. Step interpolation accurately represents discrete on/off behavior. PV is the sole exception — solar output follows the sun's arc so linear is faithful.
There was a problem hiding this comment.
Pull request overview
This PR adjusts chart interpolation to better represent discrete circuit state changes by using step interpolation for most circuit graphs, while keeping PV charts linear to reflect solar’s gradual ramps.
Changes:
- Pass a PV/linear-interpolation flag from circuit DOM updates into chart rendering.
- Extend chart update/options builders to support PV-specific interpolation behavior.
- Regenerate the bundled
dist/span-panel-card.jsoutput to reflect the new interpolation logic.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/core/dom-updater.ts | Determines whether a circuit is PV and passes that into chart updates. |
| src/chart/chart-update.ts | Extends updateChart to forward PV interpolation preference into option building. |
| src/chart/chart-options.ts | Adds ECharts step series option for non-PV charts (linear for PV). |
| dist/span-panel-card.js | Rebuilt bundle incorporating the interpolation changes. |
Circuit graphs previously used linear interpolation between data points, creating misleading diagonal ramps for instantaneous value changes. Step interpolation accurately represents discrete on/off behavior. Continuous signals (PV solar arc, BESS SoC/SoE) use linear interpolation.
cayossarian
force-pushed
the
fix/graph_fidelity
branch
from
6b4c8c1 to
12752ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circuit graphs previously used linear interpolation between data points, creating misleading diagonal ramps for instantaneous value changes. Step interpolation accurately represents discrete on/off behavior. PV is the sole exception — solar output follows the sun's arc so linear is faithful. Resolves Issue #5