Repository navigation
Record the minor findings left after PR 36 (D9, D14, ISSUES) - #40
Merged
Merged
Conversation
Docs only. The independent check of PR 36 (9047807, v0.2.1-r2) left eleven minor findings standing. Each was read again in the code and probed (guard on fixtures and on the real tree, its test file with six mutants) before it was written down: - D9: the shared two-factor panel (twofactor.tsx), ImportDialog, ConnectionDetail and DriveBrowser keep a finished sentence in state; the Sections checklist is not found by the setError/setFailure search; the two PlanDialog setFailure calls are checked by nothing. - D14 (new D14a to D14f): a callback parameter named like an import makes a function a translator; wrapper forms and parenthesised initialisers in parametersOf; an unspaced comparison hides the dependencies; a function type in a return annotation and if/while/switch conditions bind names; six mutants no fixture kills and one vacuous row; two nits. - D15 (new D15a to D15c): the end of e2e test 16, the useRecord to remember() glue, and the PlanDialog wording have no test that fails. - WORKFLOWS-LISTS-DASHBOARDS.md: GROUPABLE limits only what a person picks; the Kanban totals also group by the currency field. No product code, test or script is changed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this records
The independent check that closed PR 36 (
9047807, tagv0.2.1-r2) left a set of minor findings standing. This PR writes them down where a maintainer will find them. Docs only:docs/ISSUES.md(D9, D14 and two new groups D14a to D14f and D15a to D15c) and one paragraph ofdocs/brand/WORKFLOWS-LISTS-DASHBOARDS.md. No product code, test or script is changed. Nothing is fixed here; every limit says why it was left and what the fix would be.Where each finding landed
docs/ISSUES.mdD14a, pointer in the D14 rowparametersOf)export const title = (t("x") + "y"), which errs the other way (a missed translator); it is the same function<)scopeAtreads non-parameter groups)marked()") was dropped:marked()has no comma cut, so there is nothing to pin; thek = first - 1mutant of the mutation matrix (M20) took its placepackages/ui/src/twofactor.tsx,ImportDialog.tsx,connectors/ConnectionDetail.tsxWORKFLOWS-LISTS-DASHBOARDS.mdGROUPABLElimits only what is picked; the Kanban totals anduseCurrencyOfalso group bycurrencywaitForResponsefix included. The 404 teardown race is written as a possibility, not a defectuseRecordglue untested)Three things I added that were not in the list, so you can drop them:
DriveBrowser.tsxin the D9 list (it came in with PR 39, after the PR 36 check, and the D9 search finds it); a correction of D9's own wording aboutconnectors/Sections.tsx(its checklist keeps its sentence insetState({ error }), which thesetError(/setFailure(search does not find; only the register export is found); and the(t("x") + "y")shape in D14b.What I verified, and how
Every sentence was checked against
origin/mainat9555614before it was written.i18nGuard.ts): ran it from a scratch script outside the repo (Node 26 type stripping) on fixtures built like the ones ini18nDeps.test.ts, and on the real tree (132 files, 60 hooks, 0 flagged). Reproduced: F-A for six parameter shapes ((t) =>,t =>,({ t }) =>,function (t),catch (t),for (const t of ...)), plus the real-tree effect (Tabs,Navigationin the translator set;dismiss,notify,submitQuickamong the locals;notifya member; a scratchuseMemoover<Tabs>and overd.notifyflagged); F-B for the five wrapper shapes and the parenthesised initialiser; F-C for<and<=unspaced, with the spaced and&&/>forms still flagged; F-D for all eight forms; F-F.i18nDeps.test.ts): ran it through a small stand-in forvite-plus/test: 30 tests, 139 assertions, 0 failed. Then six mutants of the guard (declared(header)dropped, thet =>branch and thefunctionbranch ofparametersOfdropped,<= 1to<= 2, the=>guard ofargumentCompletedropped,k = first - 1tok--): all six still pass 139/139, and each is killed by the input named in D14e. A sanity mutant (<= 0) is killed, so the stand-in does fail when it should. The fourth header of the F1 loop flags once under the old reading of the header too; with the bodyfmt.money(1)it flags once now and zero times under the old reading.twofactor.tsx,Security.tsx,ImportDialog.tsx,ConnectionDetail.tsx,Sections.tsx,PlanDialog.tsx,useServer.ts,lastRecord.ts,KanbanView.tsx,useAggregate.ts,aggregate.rs(cmp_keys,TextOrder),F::new(defaultFieldKind::Text) and the sales and invoicingcurrencyfields; the e2e fixtures (allowHttpErrors, themodule.uninstallteardown) andUnknownCommandmapping to 404; no test file underweb/mentionsPlanDialogorsetFailure; no DOM or hook test library in the back office.Intl.supportedValuesOf("currency")sort into one order in all seven languages withIntl.Collator(lang, { numeric: true, sensitivity: "base" }). That is the browser collator; the server'sicu_collatorwas not run.ISSUES.mdand one paragraph of the brand doc.git merge-treeagainstfeat/oidc-core(PR 37),feat/mileage-iosandfeat/mileage-appauto-mergesdocs/ISSUES.mdwithout conflict (those branches have conflicts of their own elsewhere, none in these two files).Not run, or not reproduced
vp check,vp test, the end-to-end suite, CI, cargo, a browser. The markdown was not rendered.🤖 Generated with Claude Code