Skip to content

fix: remove logo and favicon default#28

Merged
ngovinh2k2 merged 1 commit into
devfrom
fix/remove-logo-and-favicon-default
Jul 3, 2026
Merged

fix: remove logo and favicon default#28
ngovinh2k2 merged 1 commit into
devfrom
fix/remove-logo-and-favicon-default

Conversation

@ngovinh2k2

Copy link
Copy Markdown
Member

What?

Remove logo and favicon default

Why?

From the request

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@ngovinh2k2
ngovinh2k2 merged commit d45dd7a into dev Jul 3, 2026
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the OrganizationThemeSerializer by replacing the SerializerMethodField fields (url_logo and url_favicon) and their respective getter methods with a custom to_representation method. This method dynamically injects the presigned S3 URLs for the logo and favicon if they are configured, and removes the fallback logic that previously returned default local static asset URLs. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ngovinh2k2
ngovinh2k2 deleted the fix/remove-logo-and-favicon-default branch July 3, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant