Skip to content

fix: auth space quota scopes#131

Merged
ngovinh2k2 merged 3 commits into
devfrom
fix/space-quota-scopes
Jul 17, 2026
Merged

fix: auth space quota scopes#131
ngovinh2k2 merged 3 commits into
devfrom
fix/space-quota-scopes

Conversation

@ngovinh2k2

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the space quota and downgrade task to use the FeatureCode enum instead of hardcoded strings. A critical issue was identified in space_downgrade_task where using the enum directly as a dictionary key for limits (which typically has string keys) could cause lookup failures; using .value is recommended to resolve this.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/space/tasks.py
@ngovinh2k2
ngovinh2k2 merged commit 63e61e8 into dev Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants