Skip to content

feat: Add, update, remove holdings with validation#43

Open
michaelvic123 wants to merge 1 commit into
SourceXXL:mainfrom
michaelvic123:feature/portfolio-holdings
Open

feat: Add, update, remove holdings with validation#43
michaelvic123 wants to merge 1 commit into
SourceXXL:mainfrom
michaelvic123:feature/portfolio-holdings

Conversation

@michaelvic123

Copy link
Copy Markdown

This PR adds features to manage holdings in portfolios:

  • Add holding to portfolio with symbol, quantity, cost basis, and chain
  • Update holding (quantity, cost basis, rebalancing)
  • Remove holding from portfolio
  • Validate asset symbols (3-10 chars)
  • Support multiple chains (Ethereum, Polygon, Binance, Solana)
  • Update portfolio value calculations on holding changes
  • Track cost basis for tax calculations
  • Prevent duplicate holdings (same symbol + chain)
  • Includes unit tests for all holding operations

Closes #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Holdings Management (Add/Update/Remove Assets)

1 participant